[aminevg]

Problem

Start a thread in a new worktree, let the first turn finish, then edit and resubmit its first message. The completed worktree setup card briefly reappears while the replacement turn starts.

Change

Use started runs in the thread's history to retire completed setup, including rewound runs. Web/desktop and mobile share this visibility rule.

Scope and approval

Small, focused fix for an obvious stale UI state bug in the existing edit flow; qualifies for the exception without a prior issue.

Verification

Extended the existing handoff regression: failed before the fix, passes after. Focused setup/chat tests and vp run check:changed pass.

Reproduced in the isolated web client with Replay (dev). Before: completed setup reappears on resubmission. After: no setup-card insertions. A temporary five-second provider handoff delay makes the transition visible in both captures; it is removed from the final diff. Native mobile and Electron were not driven; affected typechecks pass.

Before:

After:

Before recording · After recording

Reviewed with sol-loop: 1 round with gpt-6.1-sol on xhigh. Sol verdict: approved.

Model: GPT-6.1-Sol on xhigh. Harness: Codex in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 9412c19

Macroscope's review found this PR approvable — Uses thread run history to prevent completed worktree setup from flashing after editing the first message across web/desktop and mobile. Running setup and failure visibility remain unchanged, with no changes to worktree operations or stored data.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The worktree setup resolver now accepts run start times instead of a turnStarted flag. Mobile and web callers pass run lists, and tests cover visibility outcomes for different run histories.

Changes: Worktree setup visibility

Layer / File(s)	Summary
Resolver rule and validation packages/client-runtime/src/worktreeSetup.ts, apps/mobile/src/features/threads/worktree-setup-state.test.ts	resolveVisibleWorktreeSetup now accepts runs with start times. For a completed snapshot, it retains the snapshot when no run has a non-null startedAt. Tests cover started runs, runs without start times, and failed or cancelled setups.
Mobile and web caller inputs apps/mobile/src/features/threads/ThreadRouteScreen.tsx, apps/mobile/src/features/threads/use-worktree-setup.ts, apps/web/src/components/chat/useWorktreeSetup.ts	Mobile and web callers pass run lists to the resolver instead of a turnStarted flag.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge, shivamhwp, t3dotgg

Merge Risk: Minimal · up to c05f6

The change retires the completed worktree setup card once any run in the thread has started. This removes the flash after editing the first message. No outstanding merge risk was found.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the fix (avoiding a worktree setup flash after editing the first message). It matches the changeset, which replaces the turnStarted input with run start times so completed setup is ret…
Description check		The description follows the repository template. It covers Problem, Change, Scope, and Verification, and it includes the model and harness line. The problem is stated with reproduction steps. The chan…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the fix (avoiding a worktree setup flash after editing the first message). It matches the changeset, which replaces the turnStarted input with run start times so completed setup is retired once started runs exist in history. The title follows the conventional commit format and is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the repository template. It covers Problem, Change, Scope, and Verification, and it includes the model and harness line. The problem is stated with reproduction steps. The change explains the started-runs visibility rule and that web and mobile share it. Scope explains why no issue link is needed, citing the small-fix exception. Verification lists the regression test, focused tests, and before/after evidence, and it states what was not checked (native mobile and Electron were not driven). Evidence links are provided for UI behavior.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 47f2e91
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: c991357b-c030-4a72-a9bc-c2ec6820f4d9

Commits

Reviewing files that changed from the base of the PR and between 9412c19 and c05f6ba.

Files selected for processing: 1

• apps/mobile/src/features/threads/ThreadRouteScreen.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[juliusmarminge]

Evidence

Create a New worktree thread with Replay (dev) / Command output, finish its first turn, then Edit from here → Revert and keep changes, append “ again”, and resubmit. Chromium, 1280×800, light theme; fresh synthetic data on each side. The base video shows the completed card at 21.8s; it stays hidden on head. Both replacement turns finish.

Before	After
47f2e91210 · Recording, flash at 21.8s	c05f6badea · Recording

Scenario file

Scenario: Completed worktree setup stays hidden when the first message is edited and resubmitted

Proven: the scenario fails on base 47f2e91210 and passes on head c05f6badea.

	Base 47f2e91210	Head c05f6badea
Result	❌ failed ASSERTION_FAILED: expected [{"text":"Fetch base branchskippedCheck out files630msInit submodulesnoneRun setup scriptskippedStart agent52msDetails","at":15882.5},{"text":"Fetch base branchskippedCheck out files630msInit submodulesnoneRun setup scriptskippedStart agent52msDetails","at":15931.09999999986}] to equal []	✅ passed
first turn complete
replacement start
replacement finished
failure

Not shown:

• Mobile and the other edit-dialog choice were not exercised; this proof covers the reported web flow with Revert and keep changes.