Skip to content

perf(server): commands stop decoding finished context transfers #31851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bowd wants to merge 1 commit into from
+22 −0
Closed

perf(server): commands stop decoding finished context transfers #31851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions apps/server/src/orchestration-v2/Orchestrator.control-reads.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,23 @@ it.effect(
yield* sql`INSERT INTO orchestration_v2_projection_context_handoffs
(context_handoff_id, thread_id, target_run_id, to_provider_thread_id, strategy, status, updated_at, payload_json)
VALUES ('obsolete-handoff', ${threadId}, 'old-run', 'old-provider-thread', 'full_thread_summary', 'ready', ${DateTime.formatIso(now)}, '{"obsolete":true}')`;
for (const status of [
"resolved_native",
"resolved_portable",
"failed",
"consumed",
"superseded",
]) {
yield* sql`INSERT INTO orchestration_v2_projection_context_transfers
(context_transfer_id, source_thread_id, target_thread_id, target_run_id,
type, status, updated_at, payload_json)
VALUES (${`obsolete-transfer:${status}`}, 'old-source', ${threadId}, NULL,
'merge_back', ${status}, ${DateTime.formatIso(now)}, '{"obsolete":true}')`;
}
assert.equal(
(yield* Effect.exit(projections.getThreadRecords(threadId, ["contextTransfers"])))._tag,
"Failure",
);
yield* orchestrator.dispatch({
type: "message.dispatch",
commandId: CommandId.make("dispatch-with-old-history"),
Expand All @@ -652,6 +669,9 @@ it.effect(
turnItemTypes: ["user_message"],
});
assert.isAbove(fresh.turnItems.at(-1)!.ordinal, 900);
// Deletion reads transfer history separately to find side chats.
yield* sql`DELETE FROM orchestration_v2_projection_context_transfers
WHERE target_thread_id = ${threadId}`;
yield* orchestrator.dispatch({
type: "thread.archive",
commandId: CommandId.make("archive-with-old-history"),
Expand Down
2 changes: 2 additions & 0 deletions apps/server/src/orchestration-v2/Orchestrator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,6 +1297,8 @@ const makeOrchestrator = Effect.fn("orchestrationV2.Orchestrator.layer")(functio
// Commands here read only undelivered or active tasks; a dispatcher thread keeps
// thousands of delivered ones, each carrying its full prompt.
omitSettledSubagents: true,
// Command decisions only consume pending forks and merge-backs.
contextTransferStatuses: ["pending"],
},
)
.pipe(
Expand Down
Loading