Skip to content

fix(web): notebook error previews no longer show terminal color codes #31929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 5 commits into from
Nov 15, 2026
+2 −2
Merged

fix(web): notebook error previews no longer show terminal color codes #31929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa62758
fix(web): notebook previews show error tracebacks line by line withou…
geezoria1337 Nov 6, 2026
7b6f6b5
Merge origin/main into fix/notebook-preview-traceback
geezoria1337 Nov 14, 2026
2bceffa
fix(shared): strip colon-form SGR from plain text
geezoria1337 Nov 14, 2026
61eb704
Merge origin/main into fix/notebook-preview-traceback
juliusmarminge Nov 15, 2026
6bc2638
Merge origin/main into fix/notebook-preview-traceback
juliusmarminge Nov 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/components/files/FilePreviewPanel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ Third}`;
output_type: "error",
traceback: [
"\u001b[31mTraceback (most recent call last):\n\u001b[0m",
"\u001b[32mCell In[3], line 1\n----> 1 fail()\n\u001b[0m\u001b[39m",
"\u001b[38:2::255:0:0mCell In[3], line 1\n----> 1 fail()\n\u001b[0m\u001b[39m",
"\u001b[31mValueError: preview proof\u001b[0m",
"final entry",
],
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/terminalOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ export function terminalOutputSpans(
return spans;
}

const SGR_PATTERN = new RegExp(`${ESC}\\[[0-9;]*m`, "gu");
const SGR_PATTERN = new RegExp(`${ESC}\\[[0-9;:]*m`, "gu");

export function terminalOutputPlainText(text: string): string {
return text.replace(SGR_PATTERN, "");
Expand Down
Loading