Repository navigation
fix(desktop): Check for Updates says when an update is available #31957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+138
−23
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9aecad3
test(desktop): reproduce silent Check for Updates when an update is f…
juliusmarminge ea23999
fix(desktop): Check for Updates says what it found
juliusmarminge d5b24d6
Merge remote-tracking branch 'origin/main' into fix/issue-31943
juliusmarminge 6ccaad0
Merge remote-tracking branch 'origin/main' into fix/issue-31943
juliusmarminge 2835aa8
Merge branch 'main' into fix/issue-31943
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: pingdotgg/t3code
Length of output: 6353
Script executed:
Repository: pingdotgg/t3code
Length of output: 38377
Script executed:
Repository: pingdotgg/t3code
Length of output: 21290
Script executed:
Repository: pingdotgg/t3code
Length of output: 14228
Handle download and install failures after confirmation.
The menu discards both results, so it shows no failure dialog when either action fails. Inspect the result and show a warning with
state.messagefor a reported failure. Handle rejected actions separately from actions already in progress.Do not rely on
status === "error"for install failures: they retaindownloaded. A successful install request can also returncompleted: false.