Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions apps/server/src/mcp/toolkits/core.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
RunId,
ScheduledTaskError,
ScheduledTask,
type ScheduledTaskUpsertInput,
RuntimeRequestId,
ThreadId,
TurnItemId,
Expand Down Expand Up @@ -724,6 +725,53 @@ it.effect("a caller cannot rewrite a scheduled task that runs above its own mode
),
);

it.effect("updating a scheduled task with freshSession saves and reports fresh sessions", () => {
const saved: Array<ScheduledTaskUpsertInput> = [];
return Effect.gen(function* () {
const server = yield* McpServer.McpServer;
const result = yield* server
.callTool({
name: "schedule_task",
arguments: { scheduledTaskId: "task-auto", freshSession: true },
})
.pipe(
Effect.provideService(McpInvocationContext.McpInvocationContext, clientScope("auto")),
Effect.provideService(McpSchema.McpServerClient, client),
);
expect(result.isError).toBe(false);
expect(saved.map((input) => input.threadMode)).toEqual(["fresh_session"]);
expect(result.structuredContent).toMatchObject({ freshSession: true });
}).pipe(
Effect.provide(
layerOrchestratorToolkit.pipe(
Layer.provideMerge(McpHttpServer.layerInProcessMcpServer),
Layer.provide(NodeCrypto.layer),
Layer.provide(Layer.mock(ThreadManagement.ThreadManagementService)({})),
Layer.provide(ServerSettings.layerTest()),
Layer.provide(Layer.mock(ProviderRegistry.ProviderRegistry)({})),
Layer.provide(Layer.mock(ProviderAdapterRegistry.ProviderAdapterRegistryV2)({})),
Layer.provide(
Layer.mock(ScheduledTaskService.ScheduledTaskService)({
list: () => Effect.succeed({ tasks: [scheduledTask("task-auto", "auto")] }),
upsert: (input) => {
saved.push(input);
return Effect.succeed({
task: { ...(scheduledTask("task-auto", "auto") as object), ...input },
} as never);
},
}),
),
Layer.provide(Layer.mock(ProjectService.ProjectService)({})),
Layer.provide(Layer.mock(SecretRequests.SecretRequests)({})),
Layer.provide(Layer.mock(PeerForwarding.PeerForwarding)({})),
Layer.provide(Layer.mock(PeerLinkRequests.PeerLinkRequests)({})),
Layer.provide(Layer.mock(PeerLinks.PeerLinks)({})),
Layer.provide(Layer.mock(RemoteDelegation.RemoteDelegation)({})),
),
),
);
});

it.effect.each([
{
scenario: "explains why a webhook task cannot run manually",
Expand Down
3 changes: 2 additions & 1 deletion apps/server/src/mcp/toolkits/orchestrator/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const handlers = {
{ refused: "schedule tasks in this environment" },
),
McpToolAccess.writes(
({ scheduledTaskId, prompt, title, schedule, enabled, bindToCurrentThread }) =>
({ scheduledTaskId, prompt, title, schedule, enabled, bindToCurrentThread, freshSession }) =>
Effect.gen(function* () {
if (scheduledTaskId === undefined) return yield* Effect.die("unreachable");
const scope = yield* McpInvocationContext.McpInvocationContext;
Expand All @@ -113,6 +113,7 @@ const handlers = {
schedule,
enabled,
bindToCurrentThread,
freshSession,
});
}),
),
Expand Down
Loading