Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/server/src/mcp/advertisedJsonSchema.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ it("drops JSON noise, merges tagged unions, and keeps null where it is required"
target: {
type: "object",
properties: {
kind: { type: "string", enum: ["url", "number"] },
kind: {
type: "string",
enum: ["url", "number"],
description: "`url` requires `url`. `number` requires `number`.",
},
url: { type: "string" },
number: { type: "integer" },
},
Expand Down
12 changes: 12 additions & 0 deletions apps/server/src/mcp/advertisedJsonSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,18 @@ const mergeTaggedObjects = (branches: ReadonlyArray<Json>): JsonObject | undefin
const requiredByAll = first.filter(
(name) => name !== tag && others.every((required) => required.includes(name)),
);
// Merging drops each tag's own required fields, so the tag says which they are.
const perTag = objects.flatMap((object, index) => {
const own = (index === 0 ? first : others[index - 1]!).filter(
(name) => name !== tag && !requiredByAll.includes(name),
);
return own.length === 0
? []
: [
`\`${String(tagOf(object, tag))}\` requires ${own.map((name) => `\`${name}\``).join(", ")}.`,
];
});
if (perTag.length > 0) (properties[tag] as JsonObject).description = perTag.join(" ");
return { type: "object", properties, required: [tag, ...requiredByAll] };
};

Expand Down
2 changes: 1 addition & 1 deletion apps/server/src/provider/agentContextBudget.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"claudeSystemAppendBytes": 5597,
"codexAdditionalContextBytes": 7327,
"mcpToolListJsonBytes": 48217
"mcpToolListJsonBytes": 48682
}
Loading