[mrlufepines]

Problem

On macOS, releasing the dictation shortcut can leave recording running in Hold mode or after a long press in Auto mode. The hook only recognizes the initiating letter's keyup, which macOS can suppress while Command is held. The composer stays frozen and the microphone keeps recording until another stop/cancel or the recording limit.

Repro with the default shortcut:

1. Select Hold mode and press Command+Shift+D.
2. Release D while still holding Command, then release the modifiers.
3. Recording should stop when the chord is released. Before this fix, it continues because no D keyup arrives.

The same sequence affects Auto when held for at least 300 ms.

Change

Remember the modifiers held when dictation starts and treat the release of any of them as the end of that chord. Unrelated key releases are ignored. The existing Auto tap/hold threshold, Toggle behavior, startup promise, and generation guard remain in use, so a hold released while the microphone is preparing stops once startup completes.

This shared web hook is also used by the desktop client. Desktop preview guest forwarding still filters modifier releases and was not verified by this change. There are no mobile, provider, wire-contract, connection-mode, or settings changes.

This takes the same approach as #31720, which its author closed without merging. Credit to Keaton-tv for that proposal; this version was written against current main after reading its diff.

Scope and approval

This qualifies for CONTRIBUTING.md's exception for a very small, focused fix for an obvious bug: Hold already promises to stop on release, but the release event available on macOS is ignored. The change only recognizes the end of the existing shortcut chord in the hook and extends its adjacent tests. It introduces no new capability, setting, default, or workflow and fixes one underlying problem.

Verification

Base: freshly fetched upstream/main at 25bf84ab07f53f141c20239c63e383823a9d5ea0.

• Added tests before changing the hook. vp test run apps/web/src/speech/useDictationShortcut.browser.test.tsx on the unchanged implementation: 5 failed, 4 passed. Failures included Meta/Shift release during startup and Hold/Auto release without a letter keyup.
• The same command after the fix: 9 passed in Chromium on macOS. Tests exercise missing letter keyup, unrelated letter/modifier releases, the Auto boundary at 299/300 ms, Toggle, later releases not stopping twice, and delayed microphone startup. The clock is mocked and startup is resolved explicitly, with no sleeps or timeouts.
• vp run check:changed: passed formatting, lint, both knip checks, affected typechecks, focused browser tests, and the affected React compiler check.

The original browser tests omit the letter keyup to exercise the sequence the hook receives. The current-head real-client pass below verifies recording capture and modifier release on Linux. Native macOS event delivery and physical speech transcription remain unverified. No visual layout changes are included.

Written by GPT-6.1 Sol in Codex, driven from T3 Code.

takeover verification at e712fd7

merged current main without rebasing and resolved the adjacent browser-test conflict by retaining both the modifier-release cases and main's escape-routing cases. the diff remains two files; no production changes beyond the contributor's fix.

• blacksmith: vp run check:changed github/main passed format, lint, both knip passes, affected typechecks, all 14 shortcut browser tests, and the react compiler check.
• real linux chrome client with the downloaded parakeet model and a pulseaudio input: releasing shift/control while d remained held stopped hold-mode recording and preserved the draft. unrelated letter/alt releases kept recording; escape cancelled and preserved the draft. no fake media APIs or mocked services.
• both independent read-only reviews approved this exact head. no bot findings or unresolved review threads. git.cafe reports mergeable with 33 successful checks and no pending or failed checks.
• native macos key delivery, physical speech transcription, desktop preview guest key forwarding, native mobile, and remote connections remain unverified. desktop preview forwarding remains outside this two-file change.

[macroscopeapp]

Approvability

Verdict: Approved at 0714939

Macroscope's review found this PR approvable — Held dictation now finishes when an activation modifier is released, addressing missing letter-key release events on macOS. Existing mode rules and recording lifecycle safeguards remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Dictation shortcut presses now retain the modifier keys held at startup. Releasing the original key or a recorded modifier ends the press; unrelated key releases do not. Browser tests cover modifier releases in hold and auto modes at different durations.

Changes: Dictation shortcut release handling

Layer / File(s)	Summary
Track and handle modifier releases apps/web/src/speech/useDictationShortcut.ts, apps/web/src/speech/useDictationShortcut.browser.test.tsx	The hook records active modifiers when a press starts and ends the press when the original key or a recorded modifier is released. Browser tests cover modifier releases in hold and auto modes at specified durations.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 3f074

Releasing a held modifier now stops dictation, which fixes the stuck-recording case on macOS. The change is narrow and tested, and no merge-blocking risk is identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: dictation stops when held shortcut modifiers are released. It follows the conventional commit format and matches the two-file change (the hook and its browser tests). …
Description check		The description follows the template. It covers Problem (macOS suppresses the letter keyup, so Hold and Auto recording keeps running), Change (remember held modifiers and end the chord on their releas…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: dictation stops when held shortcut modifiers are released. It follows the conventional commit format and matches the two-file change (the hook and its browser tests). It is specific enough for a teammate scanning history.

Full details: Description check

Explanation

The description follows the template. It covers Problem (macOS suppresses the letter keyup, so Hold and Auto recording keeps running), Change (remember held modifiers and end the chord on their release), Scope (a small fix for an obvious bug, with the CONTRIBUTING.md exception argued), and Verification (failing-then-passing tests, check:changed results, a real Linux Chrome client run, and unverified areas). The template's comment about the agent model line is covered by the 'Written by' line. The Scope section links no issue. It cites a prior PR (#31720) and says a maintainer request is not involved. The reviewer may still want an issue link to show the bug, as the template asks.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 015eba4
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5c2faa93-7a92-4d84-a6e7-480db1507b95

Commits

Reviewing files that changed from the base of the PR and between e712fd7 and 3f07448.

Files selected for processing: 1

• apps/web/src/speech/useDictationShortcut.browser.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

takeover verification at e712fd7

merged current main without rebasing and resolved the adjacent browser-test conflict by retaining both the modifier-release cases and main's escape-routing cases. the diff remains two files; no production changes beyond the contributor's fix.

• blacksmith: vp run check:changed github/main passed format, lint, both knip passes, affected typechecks, all 14 shortcut browser tests, and the react compiler check.
• real linux chrome client with the downloaded parakeet model and a pulseaudio input: releasing shift/control while d remained held stopped hold-mode recording and preserved the draft. unrelated letter/alt releases kept recording; escape cancelled and preserved the draft. no fake media APIs or mocked services.
• both independent read-only reviews approved this exact head. no bot findings or unresolved review threads. git.cafe reports mergeable with 33 successful checks and no pending or failed checks.
• native macos key delivery, physical speech transcription, desktop preview guest key forwarding, native mobile, and remote connections remain unverified. desktop preview forwarding remains outside this two-file change.

earlier verification at 0714939

verified the web flow as-is at 07149390d1ce2a97b5a3a40d90caa3393ea16358 on a linux boat vm, using repo playwright and /usr/bin/google-chrome against vp run dev. main and the pr ran separately, with isolated state and only one dev server running at a time.

• on github/main (6c9adfb2739205244b84e607736f6fd8b4611e69), hold mode kept recording after releasing control and shift without a d keyup. on the pr, the same sequence stopped recording. these were trusted browser keyboard events; d keyup was withheld until after the observation.
• hold also stopped on normal d release. unrelated letter/modifier releases left recording running. escape cancelled and preserved the draft.
• auto long presses stopped on modifier release. an auto tap below 300 ms kept recording, then stopped on the next press. toggle kept recording after release and stopped on the next press.
• created the project and threads through the app against the real git repo. real codex gpt-6.1-sol turns completed on both versions. after the pr release check, the composer submitted another turn and received composer works after dictation release.
• downloaded the real parakeet model through voice settings. capture used the vm's silent pulseaudio monitor exposed as an input source, without fake media APIs or mocked services. stopping removed chrome's active capture stream and displayed the expected no speech detected result.
• all 9 existing shortcut browser tests passed through blacksmith. the existing head has 31 successful ci checks. no source changes or pushes were needed.

before, after, and the 6-second interaction recording use matching conversation/draft data. uploaded images, video playback, and seeking were checked.

Not verified

• native macos command-key suppression, physical microphone input, spoken transcription accuracy, windows, native mobile, and remote/tunnel connections were not exercised on this linux vm. the linux release sequence verifies the hook behavior, not macos event delivery.
• native desktop preview annotation dictation was not exercised. source inspection found that apps/desktop/src/preview/PickPreload.ts still forwards only the initiating letter's keyup, so modifier releases may never reach this hook on that path. this web verification does not establish that the desktop annotation case is fixed.

[juliusmarminge]

Evidence

Real web app in Linux Chromium, 1280×800, light theme, fresh synthetic state on each commit, local Parakeet transcription and synthetic microphone tone. MacIntel platform and omission of D keyup emulate the reported macOS stream.

In a new-thread composer containing draft before dictation, hold Meta+Shift+D for 2.5 seconds, release only Shift and Meta, and wait six seconds. Repeat in Hold and Auto. The ordinary D-keyup control stops on both commits. Auto taps and Toggle keep recording until explicitly cancelled on both commits.

Proven: scenarios:prove exited 0; the scenario failed on base and passed on head.

Interaction	Before: 015eba4083	After: 3f07448ec3
Hold, six seconds after modifier release
Auto long press, six seconds after modifier release
Auto tap continues recording
Toggle continues recording
Full scripted interaction	Before recording	After recording

Scenario source · Runner proof

Not shown:

• Native macOS suppression of the letter keyup was not exercised; the reported event stream was deliberately emulated in Linux Chromium by withholding D keyup.
• Release during deliberately delayed microphone startup and dictation in other editors were not separately exercised.