[geezoria]

Problem

Opening an OpenDocument presentation (.odp) in the file preview prints each slide's speaker notes as if they were slide text, at the end of the slide. Speaker notes are not part of the slide, so the preview should not show them there.

To reproduce, open any .odp that has speaker notes. LibreOffice's own test deck search-all-notes.odp shows it.

Change

odfHtml already skips parts of an OpenDocument file that are not on the page, such as office:annotation and text:tracked-changes. It now skips presentation:notes too.

That element's namespace was missing from namespacePrefixes, so it reached odfHtml as {urn:…:presentation:1.0}notes. The change adds the namespace so the skip list can name it. Nothing reads presentation:* names otherwise.

Scope and approval

This is a very small fix for an obvious bug, so it has no prior issue: text that is not on the slide appears on the slide. It adds one namespace entry and one skip-list entry, and no product behavior changes beyond removing the notes.

Duplicate searches across PRs and issues, in all states, found nothing that overlaps: odp speaker notes, presentation notes preview, OpenDocument presentation preview, odp preview, OpenDocument preview, presentation:notes, and extendedDocumentPreview. The only open PR touching this file, #31929, changes notebook outputs. #31868 only changes the "1 slide" label.

Verification

Failing test. I extended the odp case of the existing reads %s text and rejects XML entities test in apps/web/src/components/files/FilePreviewPanel.test.ts instead of adding a new one, so the slide now carries a presentation:notes block.

• Without the fix: vp test run apps/web/src/components/files/FilePreviewPanel.test.ts -t "reads" fails with expected '<h2>Launch plan</h2><p>Speaker only</…' not to contain 'Speaker only'.
• With the fix, the whole file passes: Tests 31 passed (31).

Real file. I ran openDocument on search-all-notes.odp, generated by LibreOfficeDev/7.2.0.0.alpha1, which has one presentation:notes block.

Before:

page1 => <p>Title</p><ul><li><p>Some text</p></li><li><p>And magic word: “Crash”<span data-odf-whitespace>&#9;</span></p></li></ul><p>Notes which include the magic word: “Crash”</p>

After:

page1 => <p>Title</p><ul><li><p>Some text</p></li><li><p>And magic word: “Crash”<span data-odf-whitespace>&#9;</span></p></li></ul>

Running client. The same file, opened from Files in a vp run dev web client on Windows.

Before:

After:

vp run check:changed origin/main passes: format, lint, knip, typecheck (2 packages), tests (2 files) and React compiler.

Not checked: mobile, which does not use this preview code, and .odp files written by apps other than LibreOffice. The element is defined by the ODF schema, so the skip does not depend on the app that wrote the file.

Implemented and verified with Claude Opus 5.5 (claude-opus-5-5) in the Claude Code harness.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at d7108cd

Macroscope's review found this PR approvable — OpenDocument previews now recognize presentation notes and omit them from rendered slides. The change is limited to preview output and leaves source documents unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The ODF preview now recognizes the presentation namespace and omits presentation:notes content. The ODP preview test includes speaker notes and checks that the rendered preview excludes them.

Changes: ODF preview content

Layer / File(s)	Summary
Presentation notes filtering apps/web/src/components/files/extendedDocumentPreview.ts, apps/web/src/components/files/FilePreviewPanel.test.ts	The ODF namespace map recognizes the presentation namespace, and odfHtml omits presentation:notes subtrees. The ODP test verifies that “Speaker only” is absent from the rendered preview.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 4c681

ODP slide previews now omit speaker notes, a narrow, low-risk change that is covered by an updated test. No actionable merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: OpenDocument slide previews no longer show speaker notes. It follows the conventional commit form and matches the code change, which adds the presentation namespace an…
Description check		The description follows the template. It covers the problem with reproduction steps, the change and why the namespace was needed, scope with a reason why no issue is linked, and verification with fail…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: OpenDocument slide previews no longer show speaker notes. It follows the conventional commit form and matches the code change, which adds the presentation namespace and skips presentation:notes in odfHtml. It is specific and clear.

Full details: Description check

Explanation

The description follows the template. It covers the problem with reproduction steps, the change and why the namespace was needed, scope with a reason why no issue is linked, and verification with failing and passing test runs, a real-file before/after, and screenshots. It also names the model and harness. The Scope section does not link an issue, but it explains why none is needed for a small obvious fix, as the template allows.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 1e9f93a
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5e752155-b211-4144-bcee-615932f4c785

Commits

Reviewing files that changed from the base of the PR and between d7108cd and 4c681f9.

Files selected for processing: 2

• apps/web/src/components/files/FilePreviewPanel.test.ts
• apps/web/src/components/files/extendedDocumentPreview.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified on a disposable linux vm with the real dev web client, repo playwright, /usr/bin/google-chrome, and codex gpt-6.1-sol turns. no application changes were needed.

• reproduced on github/main (61cb845d9699d0ecce5a9b660d3b32907914df8b): Files → search-all-notes.odp renders the speaker note below the slide bullets.
• checked the exact pr head d7108cd0eb984d685228c844f825f3a17ea11ddd: the same file renders its title and both bullets, with the speaker note omitted. main was stopped before starting the pr server.
• created the project and thread through the app. a real codex turn downloaded the LibreOffice document; another turn on the pr inspected its source and confirmed the note still exists. document sha256: d76b50633e908514d3fec7b22af6ed9455f0483b8d71c893db1e65dc80eb2c21.
• nearby checks passed: an odt created by the provider renders its body while omitting its annotation; markdown preview renders; switching back to odp preserves slide content; zoom changes to 125% and resets to 100%.
• ran the existing FilePreviewPanel.test.ts through blacksmith: 31 tests passed. the pr has 31 successful ci checks, none pending or failing.

before, main:

after, exact pr head:

file switching and zoom (animated recording):

Not verified

native desktop shells on linux, macos or windows, native ios/android clients, and odp files produced by applications other than LibreOffice were not exercised. this pass verifies the web preview path changed by this pr.

[juliusmarminge]

Evidence

Opened the unchanged LibreOffice search-all-notes.odp fixture through a thread’s right panel → Files on both commits. Chromium, 1280×800, light theme, fresh isolated state. The base shows speaker notes as slide content; the fix omits them while preserving the title and bullets.

Before	After
1e9f93a48e	4c681f9e1b

Scenario source · Before recording · After recording

Scenario proof exited 0: failed on base because the speaker-note paragraph was visible; passed on head.