Repository navigation
Conversation
With several instances of one driver (one Claude Code instance per account), nothing said which one a thread runs on. The picker rail now marks the active instance with a dot and an "Active" tooltip, even while another instance is browsed. When same-driver instances could be confused, the composer model button names the instance in its tooltip and accessible name.
github-actions
Bot
added
vouch:unvouched
The composer model button's hover now uses the same ThreadHoverCard as the agents panel when same-driver instances could be confused: the model as the title, the instance with its icon and badge, then effort and the shortcut. Other pickers keep the plain tooltip.
github-actions
Bot
added
size:M
Member
|
This has been a draft with no activity for more than three days, so it is being closed: the open pull requests are kept to work that is ready to be looked at. Nothing is lost, the branch stays. When the work is ready, open a new pull request for it; this one will not be reopened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With several instances of one driver (for example one Claude Code instance per account), the main thread does not show which instance it runs on. The composer model button shows only "Opus 5.5 Medium" and has no tooltip. The picker rail highlights only the instance being browsed, and with favorites it opens on Favorites, so the active instance is out of view.
Change
ModelPickerSidebartakes the thread'sactiveInstanceId. That instance's rail icon gets a small success-colored dot, "· Active" in its tooltip, andaria-current="true". The dot stays while another instance is browsed.ProviderModelPickeradds the instance display name to the trigger's accessible name, and shows a hover card when same-driver instances could be confused (the existingshouldShowInstanceBadgerule). The card reusesThreadHoverCard, the card of the agents panel: the model as the title, the instance with its icon and badge, then effort and the shortcut. With one instance per driver, the composer button keeps the no-tooltip behavior from fix(web): model picker stays open until dismissed, with a Show more row #28076.Scope and approval
Proposed in #33322 (Ideas), which follows up #17506. Draft until a maintainer approves the direction and scope there. Per-instance icons and badge labels are out of scope; they are covered by #15185 and #26236.
Verification
ProviderModelPicker.browser.test.tsx: the existing two-instance case now asserts that the active instance keepsaria-current="true"while the other instance is browsed. It fails without the rail change (aria-currentmissing) and passes with it.vp run check:changedpasses (format, lint, knip, typecheck, tests, React compiler).Not checked: the desktop app build (it wraps the same web components) and mobile (unchanged).