Repository navigation
fix(usage): refetch cached rates early for a model they do not list #33725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 2 commits into
pingdotgg:main
from
DrSeedon:fix/usage-refetch-unlisted-model-rates
Nov 14, 2026
+114
−14
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear the checked-model set when a fetch replaces the rate table.
checkedUnlistedModelsis only added to. A successful fetch replacesrates, but the set keeps its entries. A model that was absent from one fetched table is then skipped by every later scan, even after it appears upstream. That model no longer triggers an early refetch until the process restarts. Its price waits for the 24-hourRATES_TTL_MSrefresh, or for another unlisted model to force a refetch. The stated intent is one check per fresh table.Clear the set when a successful fetch installs a new table:
Suggested fix
rates = fetched.parsed; ratesFetchedAtMs = now; ratesLastFailedAtMs = null; + checkedUnlistedModels.clear(); ratesStatus = "fresh";loadRatesruns only aftermakefinishes initializing, so it can reference the set declared later in the same scope. Add the table-replacement sequence to the existing test atapps/server/src/usage/UsageService.test.ts:3774.