Repository navigation
feat(web): select a submodule repository for diff review #34105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NeilMazumdar
wants to merge
16
commits into
pingdotgg:main
Choose a base branch
from
NeilMazumdar:feature/submodule-diffs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+898
−112
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e58175d
feat(git): show file diffs inside submodules
NeilMazumdar e014d3c
fix(git): preserve submodule paths and bounded pointer fallbacks
NeilMazumdar 37edc71
fix(git): keep submodule patches in bounded review fallbacks
NeilMazumdar 84b02ed
fix(git): align submodule fallback metadata with patch paths
NeilMazumdar fbcf0b2
feat(git): select a repository for diff review
NeilMazumdar 4a9b933
fix(git): keep repository review paths and scopes consistent
NeilMazumdar f1f44f8
fix(git): refresh and deduplicate repository choices
NeilMazumdar c73f7b8
fix(web): keep literal child paths and the loading state during repos…
NeilMazumdar 4429ed7
fix(mobile): reselecting the active repository keeps the selected sec…
NeilMazumdar b9b72b9
test(server): give the submodule clone a Git identity before committing
NeilMazumdar 85434ce
fix(web,mobile): show a failed repository discovery instead of the pa…
NeilMazumdar c33562f
fix(web,mobile): retry a failed repository discovery without losing t…
NeilMazumdar 07ca7d5
chore: merge upstream main into submodule diff branch
NeilMazumdar 0e2a526
Merge remote-tracking branch 'github/main' into feature/submodule-diffs
maria-rcks 5c1110d
perf(web): only discover review repositories while the Diff panel is …
maria-rcks a4237c6
test(web): drop the removed keep-on-open argument after merging main
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.