Repository navigation
feat(voice): an optional sound tells you dictation is listening #34265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
screen-gd
wants to merge
1
commit into
pingdotgg:maria/redesign/6-workspace-panes
from
screen-gd:feat/voice-recording-cue
+183
−1
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| MIT License | ||
|
|
||
| Copyright (c) 2026 Christopher Langton | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import type { SpeechRecordingCueSound } from "@t3tools/contracts"; | ||
|
|
||
| import analogUrl from "../assets/speech-cues/analog.wav?url"; | ||
| import classicUrl from "../assets/speech-cues/classic.wav?url"; | ||
| import clickUrl from "../assets/speech-cues/click.wav?url"; | ||
| import signatureUrl from "../assets/speech-cues/signature.wav?url"; | ||
| import softUrl from "../assets/speech-cues/soft.wav?url"; | ||
| import thockUrl from "../assets/speech-cues/thock.wav?url"; | ||
| import woodUrl from "../assets/speech-cues/wood.wav?url"; | ||
|
|
||
| // The start sounds from https://github.com/anomalyco/hex, unmodified. See speech-cues/LICENSE. | ||
| export const RECORDING_CUE_SOUNDS = { | ||
| classic: { label: "Classic", url: classicUrl }, | ||
| signature: { label: "Signature", url: signatureUrl }, | ||
| click: { label: "Click", url: clickUrl }, | ||
| soft: { label: "Soft tone", url: softUrl }, | ||
| wood: { label: "Wood", url: woodUrl }, | ||
| analog: { label: "Warm synth", url: analogUrl }, | ||
| thock: { label: "Thock", url: thockUrl }, | ||
| } as const satisfies Record<SpeechRecordingCueSound, { label: string; url: string }>; | ||
|
|
||
| const cueElements = new Map<SpeechRecordingCueSound, HTMLAudioElement>(); | ||
|
|
||
| function cueElement(sound: SpeechRecordingCueSound): HTMLAudioElement { | ||
| const existing = cueElements.get(sound); | ||
| if (existing) return existing; | ||
| const created = new Audio(RECORDING_CUE_SOUNDS[sound].url); | ||
| cueElements.set(sound, created); | ||
| return created; | ||
| } | ||
|
|
||
| /** Loads a cue ahead of time so it can play the moment recording begins. */ | ||
| export function preloadRecordingCue(sound: SpeechRecordingCueSound): void { | ||
| cueElement(sound); | ||
| } | ||
|
|
||
| // Longer than every cue, so a stalled or blocked element cannot hold back recording. | ||
| const CUE_WAIT_LIMIT_MS = 1_000; | ||
|
|
||
| /** Plays the sound that tells the user dictation is listening; resolves once it has finished. */ | ||
| export function playRecordingCue(sound: SpeechRecordingCueSound): Promise<void> { | ||
| const audio = cueElement(sound); | ||
| audio.currentTime = 0; | ||
| return new Promise((resolve) => { | ||
| const finish = () => { | ||
| clearTimeout(limit); | ||
| audio.removeEventListener("ended", finish); | ||
| resolve(); | ||
| }; | ||
| const limit = setTimeout(finish, CUE_WAIT_LIMIT_MS); | ||
| audio.addEventListener("ended", finish); | ||
| audio.play().catch(finish); | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 High
speech/recordingCue.ts:50When cue playback is delayed or stalls,
playRecordingCueresolves after 1 second while the audio can still play into the recording and live transcription. The timeout only callsfinish, which does not stop the audio; pause and reset it on the timeout path before resolving.🤖 Copy this AI Prompt to have your agent fix this: