Skip to content

fix(web): voice settings mark the rows saved on this device #34312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InvixGG wants to merge 3 commits into
base: main
Choose a base branch
from
+29 −12
Open

fix(web): voice settings mark the rows saved on this device #34312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b77c818
fix(web): voice settings mark the rows saved on this device
InvixGG Nov 11, 2026
349a133
Merge upstream main into fix/voice-settings-device-scope
InvixGG Nov 12, 2026
90d2a03
Merge origin/main into fix/voice-settings-device-scope
juliusmarminge Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions apps/web/src/components/settings/VoiceSettingsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,23 @@ function ModelBadge(props: { icon: ReactNode; label: string; tooltip: string })
);
}

// The scope picker above only changes serverScoped rows, so rows saved on this client say so.
function DeviceSettingTitle(props: { children: string }) {
return (
<span className="inline-flex items-center gap-1.5">
{props.children}
<Tooltip>
<TooltipTrigger render={<Badge variant="outline" size="sm" tabIndex={0} />}>
This device
</TooltipTrigger>
<TooltipPopup side="top">
Saved on this device, whatever scope is selected above.
</TooltipPopup>
</Tooltip>
</span>
);
}

function ModelCard(props: ModelCardProps) {
const { model } = props;
const downloading = model.state === "downloading" || model.state === "verifying";
Expand Down Expand Up @@ -1289,8 +1306,8 @@ export function VoiceSettingsPanel() {
<SettingsSection id="voice-input" title="Input">
<SettingsRow
{...searchableSetting("voice-microphone")}
title="Microphone"
description="Voice input uses the first connected microphone in this list."
title={<DeviceSettingTitle>Microphone</DeviceSettingTitle>}
description="Audio is recorded on this device and transcribed wherever you choose under Transcription. Voice input uses the first connected microphone in this list."
control={
<Tooltip>
<TooltipTrigger
Expand Down Expand Up @@ -1321,7 +1338,7 @@ export function VoiceSettingsPanel() {
/>
<SettingsRow
{...searchableSetting("dictation-shortcut-mode")}
title="Dictation shortcut"
title={<DeviceSettingTitle>Dictation shortcut</DeviceSettingTitle>}
description={`${SHORTCUT_MODES[settings.voiceShortcutMode].hint}.`}
control={
<Select
Expand Down Expand Up @@ -1505,7 +1522,7 @@ export function VoiceSettingsPanel() {
{(model || destination.cloudProvider) && (
<SettingsRow
{...searchableSetting("speech-language")}
title="Language"
title={<DeviceSettingTitle>Language</DeviceSettingTitle>}
description={
destination.cloudProvider
? "The provider detects your language automatically."
Expand All @@ -1522,7 +1539,7 @@ export function VoiceSettingsPanel() {
)}
{model?.supportsTranslation ? (
<SettingsRow
title="Translate to English"
title={<DeviceSettingTitle>Translate to English</DeviceSettingTitle>}
description="Speak any language and get English text."
control={
<Switch
Expand All @@ -1537,7 +1554,7 @@ export function VoiceSettingsPanel() {
) : null}
<SettingsRow
{...searchableSetting("speech-silence-filtering")}
title="Silence filtering"
title={<DeviceSettingTitle>Silence filtering</DeviceSettingTitle>}
description={
destination.cloudProvider === "openai"
? "OpenAI handles silence itself."
Expand All @@ -1556,7 +1573,7 @@ export function VoiceSettingsPanel() {
/>
<SettingsRow
{...searchableSetting("remove-filler-words")}
title="Remove filler words"
title={<DeviceSettingTitle>Remove filler words</DeviceSettingTitle>}
description="Drop “um” and “uh” from transcripts."
control={
<Switch
Expand Down Expand Up @@ -1586,8 +1603,8 @@ export function VoiceSettingsPanel() {
<SettingsSection id="voice-dictionary" title="Dictionary">
<SettingsRow
{...searchableSetting("speech-dictionary")}
title="Your dictionary"
description="Names and terms to spell your way, saved on this device."
title={<DeviceSettingTitle>Your dictionary</DeviceSettingTitle>}
description="Names and terms to spell your way."
>
<div className="mt-3 pb-2">
<DictionaryEditor
Expand All @@ -1602,7 +1619,7 @@ export function VoiceSettingsPanel() {

<SettingsSection id={searchableSetting("speech-post-processing").id} title="Cleanup">
<SettingsRow
title="Clean up transcripts"
title={<DeviceSettingTitle>Clean up transcripts</DeviceSettingTitle>}
description="Off by default. Sends the transcript and nearby draft text, never audio, to the cleanup model."
control={
<Switch
Expand All @@ -1614,7 +1631,7 @@ export function VoiceSettingsPanel() {
/>
{cleanupEnabled ? (
<SettingsRow
title="Instructions"
title={<DeviceSettingTitle>Instructions</DeviceSettingTitle>}
description={
settings.speechPostProcessingPrompt.mode === "custom"
? "Your own instructions for cleanup."
Expand Down Expand Up @@ -1672,7 +1689,7 @@ export function VoiceSettingsPanel() {
{cleanupEnabled ? (
<SettingsRow
{...searchableSetting("speech-correction-word")}
title="Correction cue"
title={<DeviceSettingTitle>Correction cue</DeviceSettingTitle>}
description="The phrase you say to fix a mistake, like “scratch that”."
control={
<Input
Expand Down
Loading