Skip to content

fix(web): NVDA browse mode reads the current thread's branch, not the previous one #34446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 3 commits into from
Nov 14, 2026
+8 −1
Merged

fix(web): NVDA browse mode reads the current thread's branch, not the previous one #34446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39a881d
fix(web): NVDA browse mode reads the current thread's branch on the b…
Nov 11, 2026
daff8fc
Merge remote-tracking branch 'origin/main' into t3/version-combobox-s…
juliusmarminge Nov 11, 2026
8fadf5b
Merge remote-tracking branch 'origin/main' into t3/version-combobox-s…
juliusmarminge Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/web/src/components/BranchToolbarBranchSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,8 @@ export function BranchToolbarBranchSelector({
}
className="min-w-0 max-w-full active:scale-100"
disabled={isInitialBranchesLoadPending || isBranchActionPending}
// NVDA browse mode re-reads a combobox when its attributes change, not when its text does.
aria-label={`Branch: ${triggerLabel}`}
>
<GitBranchIcon
className={cn(
Expand All @@ -794,7 +796,12 @@ export function BranchToolbarBranchSelector({
)}
/>
<ComposerContextLabel displayMode={displayMode}>
<MiddleTruncate value={triggerLabel} variant="cap-aligned" className="w-full" />
<MiddleTruncate
value={triggerLabel}
variant="cap-aligned"
className="w-full"
aria-hidden
/>
</ComposerContextLabel>
</ComboboxTrigger>
</span>
Expand Down
Loading