Skip to content

fix(web): favorites tab shows starred models with a visible filled star #34793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prior wants to merge 1 commit into from
+1 −4
Closed

fix(web): favorites tab shows starred models with a visible filled star #34793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/web/src/components/chat/ModelListRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ export const ModelListRow = memo(function ModelListRow(props: {
acpRegistryAgentId?: string | undefined;
acpRegistryIconUrl?: string | undefined;
isFavorite: boolean;
/** In Favorites every row is starred, so the star shows only on hover. */
favoriteStarOnHover?: boolean;
isSelected: boolean;
/** Marks this instance apart from another of the same provider. */
showInstanceBadge: boolean;
Expand Down Expand Up @@ -121,7 +119,7 @@ export const ModelListRow = memo(function ModelListRow(props: {
className={cn(
"size-3.5 sm:size-3",
props.isFavorite && "fill-current text-warning",
(!props.isFavorite || props.favoriteStarOnHover) &&
!props.isFavorite &&
"opacity-0 group-hover:opacity-100 group-data-highlighted:opacity-100 in-focus-visible:opacity-100 pointer-coarse:opacity-100",
)}
/>
Expand Down
1 change: 0 additions & 1 deletion apps/web/src/components/chat/ModelPickerContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,6 @@ export const ModelPickerContent = memo(function ModelPickerContent(props: {
? selectedModelKeySet.has(modelKey)
: modelKey === activeModelKey
}
favoriteStarOnHover={selectedInstanceId === "favorites" && !isSearching}
showInstanceBadge={badgedInstanceIds.has(model.instanceId)}
showNewBadge={model.badge === "new"}
unavailable={model.isUnavailable === true}
Expand Down
Loading