Repository navigation
fix(contracts): agents keep working after starting an async delegate #34924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+29
−12
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9267283
fix(contracts): agents keep working after starting an async delegate
juliusmarminge b33fc83
Merge origin/main into factory/issue-27126
juliusmarminge 3d525fa
fix(contracts): decode a running task's next from linked environments…
juliusmarminge c58d6f0
Merge branch 'main' into factory/issue-27126
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case does not check that the delegation starts before the rebase.
The
child-async-delegate-keeps-workingcase requires adelegate_taskcall and a rebase shell command. It has no ordering check. A run that rebases first and delegates afterward passes every expectation. The brief requires the advisory check to start before the rebase, so the case can miss the regression it was written to catch.The existing
orderkey compares tool-call names only (run.ts:1840-1844). It cannot place the rebase shell command in sequence withdelegate_task. Enforcing this order requires a grader change, such as a positional check that compares the index of the delegate call with the index of the first matching shell command. Pick a design for that change before adding the check.Make
child-async-delegate-keeps-workingfail on the old text in at least half of its samples.evals/README.mddefines a case failure as half or more of its samples failing. The reported old-text baseline is 4 of 24 samples, which does not meet that threshold. As written, the case does not fail on the old text, so it is unlikely to detect a regression of this change in a single run.Choose one of these corrections:
nextwording fails in at least 12 of 24 samples. Keep theshellMust,shellMustNot, andcallschecks unchanged. Do not loosen them.evals/README.mdto say so. Then state that rule for this case.