Repository navigation
fix(opencode): a resumed task subagent's turn no longer collides with its first #34961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+155
−5
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
788584a
test(opencode): resumed task child turns append to the child's ordinals
juliusmarminge c0c5884
fix(opencode): a resumed task subagent's turn no longer collides with…
juliusmarminge 3d13b4d
Merge remote-tracking branch 'origin/main' into factory/issue-19883
juliusmarminge 8c82bc4
docs(opencode): note why the stored user-message count cannot reuse a…
juliusmarminge 82842a9
fix(opencode): recover a resumed child's ordinal from its prompt's st…
juliusmarminge 3f86ef1
Merge remote-tracking branch 'origin/main' into factory/issue-19883
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contain failures from the added history lookup.
If
session.messagesfails during resumed-child initialization, its error escapes throughemitSubagentandhandleEvent.Stream.runForEach(handleEvent)then terminates. The cleanup at Line 2763 marks the native stream as failed, fails every active turn, and ends the event queue. LaterstartTurncalls reject the session.Handle this lookup failure without terminating the event subscription. Keep the ordinal failure explicit for the affected operation; do not fall back to ordinal 1.