Repository navigation
fix(server): preview browser downloads Chrome 157.0.8103.78 with its security fixes - #34962
Conversation
…security fixes The server's preview browser was pinned to Chrome for Testing 157.0.8103.38, which lacks the security fixes in 157.0.8103.50 (including an exploited CVE) and 157.0.8103.78. Bump the pin to the current Stable, 157.0.8103.78, with sizes and SHA-256s computed from each chrome-headless-shell archive. Fixes #34920 AI-assisted; verified with the tests and tools listed above.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Updates the preview browser to a newer Chrome patch release and refreshes its platform archive metadata. Existing integrity checks and on-demand installation behavior remain unchanged, keeping the update's exposure limited. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…security fixes (pingdotgg#34962) (cherry picked from commit 928dd04)
…security fixes (pingdotgg#34962) (cherry picked from commit 928dd04)
Moves the pinned Chrome for Testing headless shell used by the server preview browser from 157.0.8103.38 to 157.0.8103.78, picking up that release's security fixes, and updates the byte size and SHA-256 pin for each of the six platform archives (linux64, linux-arm64, mac-arm64, mac-x64, win32, win64). Download, verification and install logic are unchanged. Every new pin was checked by downloading each archive from storage.googleapis.com/chrome-for-testing-public/157.0.8103.78: all six byte counts and SHA-256 hashes match exactly. The linux64 archive unzips and its binary reports 'Google Chrome for Testing 157.0.8103.78'. The author's commit is kept as-is, with a clean merge of origin/main on top; the diff against main is still only these 13 lines in PreviewBrowser.ts.
Fixes #34920
Reproduction on main
Not executed during screening. Start a main build with isolated T3 home state and no cached preview browser, connect the web client, create a thread, and select Browser in its right panel. Wait for installation, then inspect the installed chrome-headless-shell version directory or run that binary with --version; main should report 157.0.8103.38. Repeat with this PR using separate isolated state; it should install and report 157.0.8103.78.
Evidence
Fresh isolated state and empty preview-browser cache on each commit. Create a replay thread, open its right panel, select Browser, wait for installation, and load a local page displaying the installed chrome-headless-shell --version output. Linux x64 web client, 1280×800, light theme; browser sandbox disabled equally on both sides for this VM.
Scenario source. Base failed the version check with 157.0.8103.38; head passed with 157.0.8103.78. Both captures and recordings were inspected.
Not shown:
Tests
vp test run apps/server/src/preview/PreviewBrowser.test.ts: 8/8 passed. vp run check:changed: format, lint, knip, typecheck (3 packages) and tests (2 files) all passed. Streamed sha256sum and byte count of all six 157.0.8103.78 archives: all match the pins. Unzipped linux64 chrome-headless-shell --version: 'Google Chrome for Testing 157.0.8103.78'.
Who did the work
Run by the t3code factory in T3 Code.