Repository navigation
fix(server): a schedule bound to an archived thread pauses instead of retrying every interval #35081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+196
−6
Closed
fix(server): a schedule bound to an archived thread pauses instead of retrying every interval #35081
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8b25005
test(server): archived destination stops a bound schedule (repro #24519)
juliusmarminge 92879e6
fix(server): a schedule bound to an archived thread pauses instead of…
juliusmarminge 7b17d33
fix(server): scheduled tasks pause after repeated failed deliveries
juliusmarminge 1a5d032
fix(server): resuming a paused task from its edit dialog resets its f…
juliusmarminge 10b2d3d
Merge remote-tracking branch 'origin/main' into factory/issue-24519-a…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
apps/server/src/persistence/Migrations/084_ScheduledTaskConsecutiveFailures.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import * as Effect from "effect/Effect"; | ||
| import * as SqlClient from "effect/sql/SqlClient"; | ||
|
|
||
| export default Effect.gen(function* () { | ||
| const sql = yield* SqlClient.SqlClient; | ||
|
|
||
| yield* sql`ALTER TABLE scheduled_tasks ADD COLUMN consecutive_failures INTEGER NOT NULL DEFAULT 0`; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard the settings save against a stale
enabledvalue.upsertreads the task, awaits several effects, and then callssaveTask. A failed run can commit between those steps and setenabledto 0 withconsecutive_failuresat 5.saveTaskthen writes theenabledvalue thatupsertread. TheCASEonscheduled_tasks.enabledtreats that stale save as an explicit re-enable and resets the failure count to 0. A title or prompt save can therefore undo an automatic pause.The
CASEcannot separate an explicit disabled-to-enabled edit from a pause that happened after the read. The write should applyenabledand the failure reset only when the storedenabledstill matches the valueupsertobserved. The existingnext_run_atguard already uses this pattern. Add a test that uses aDeferredto hold the save until a fifth failure commits. The test should assert that the task stays paused and thatconsecutive_failuresstays at 5.