Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Stopped PR watches now explain when the server’s host CLI is missing or unauthenticated and provide targeted recovery guidance. Existing retry thresholds and watch-stop behavior remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Use the PullRequestUnavailableError message, which carries each host's requirement text, instead of fixed "host CLI" wording that is wrong for token and API-credential hosts. Trim the test to one case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An already-active PR watch loses
PullRequestUnavailableErrorwhen it gives up after eight failed host reads. A missing or unauthenticated server CLI therefore produces only "could not read it", encouraging another watch attempt without fixing the blocker. This was observed with a Windows T3 server whose Gitea CLI was missing while repository access from WSL worked.Carry the final typed CLI failure into the stop notification and tell the agent to install/authenticate the host CLI in the T3 Code server environment before rearming. Only two files change. Retry limits, watch termination, other failures, and watch registration keep their existing behavior; raw causes and subprocess output never enter the wake.
This complements #33389 (registration preflight) and #32694 (ongoing forbidden/unauthenticated provider access), which do not cover these ongoing
cli-missing/cli-unauthenticateddiagnostics.Verification
0286cbfb5e, based ondd9c2f8e21: 160/160 tests passed acrossruntimeLayer.test.tsandAgentContextBudget.test.ts. Format, lint, both Knip passes, GraphQL generation check, and Effect-tsgo typechecks for all three affected packages passed.watching:false, exactly one wake, its specific summary, and server-environment recovery guidance after eight failures. No live installation or credentials were changed for verification.vp run check:changed --concurrency 2was attempted but its cache-input Git enumeration recursively traversed pnpm junctions on Windows, emittedFilename too longwarnings, and was stopped before gates started. Its selected gates listed above were run separately and passed on the final head. Paid model evals were not run: this checkout has neither an Anthropic key nor the eval harness'svibeproxyconfiguration. The changed wake has not been exercised through a real agent turn.Written with gpt-6.1-sol in the Codex harness; independently reviewed with gpt-6-luna.