Repository navigation
feat(projects): a project can track several repositories #35921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
1
commit into
main
Choose a base branch
from
t3/multi-repo-1-tracked-repos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,855
−182
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import type { WorkspaceScannedFolder } from "@t3tools/contracts"; | ||
|
|
||
| import { ListToggleRow } from "../../components/ui/ListToggleRow"; | ||
|
|
||
| /** Describes a set of scanned folders: "1 repository", "3 folders". */ | ||
| export function scannedFolderCountLabel(folders: ReadonlyArray<{ isGitRepository: boolean }>) { | ||
| const allRepositories = folders.every((folder) => folder.isGitRepository); | ||
| if (folders.length === 1) return allRepositories ? "1 repository" : "1 folder"; | ||
| return `${folders.length} ${allRepositories ? "repositories" : "folders"}`; | ||
| } | ||
|
|
||
| export function ScannedFolderRows(props: { | ||
| readonly folders: ReadonlyArray<WorkspaceScannedFolder>; | ||
| readonly deselectedPaths: ReadonlySet<string>; | ||
| readonly disabled?: boolean; | ||
| readonly onDeselectedPathsChange: (paths: ReadonlySet<string>) => void; | ||
| }) { | ||
| return props.folders.map((folder) => ( | ||
| <ListToggleRow | ||
| key={folder.path} | ||
| icon="folder" | ||
| label={folder.name} | ||
| description={folder.isGitRepository ? folder.path : `Folder · ${folder.path}`} | ||
| disabled={props.disabled} | ||
| value={!props.deselectedPaths.has(folder.path)} | ||
| onValueChange={(selected) => { | ||
| const next = new Set(props.deselectedPaths); | ||
| if (selected) next.delete(folder.path); | ||
| else next.add(folder.path); | ||
| props.onDeselectedPathsChange(next); | ||
| }} | ||
| /> | ||
| )); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bind scan selections to their environment.
foundstores scan results without the environment they came from. IfenvironmentIdchanges while the selection is shown, the screen still displays it. Both add buttons then callcreateProjectfor the new environment with the old paths and selected folders. This can create a project on the wrong environment with tracked folders that were never scanned there.Store the environment with the selection, and render the selection only for the same environment.
Suggested fix
const [found, setFound] = useState<{ + readonly environmentId: string; readonly workspaceRoot: string; readonly lookupPath: string; readonly folders: ReadonlyArray<WorkspaceScannedFolder>; } | null>(null);