Repository navigation
perf(scripts): each new scenario no longer pays 1.6 s to add and remove its project #35986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kdy1
wants to merge
4
commits into
pingdotgg:main
Choose a base branch
from
kdy1:scenarios-project-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−8
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fba53b6
perf(scripts): each new scenario no longer pays 1.6 s to add and remo…
kdy1 f769923
Merge remote-tracking branch 'origin/main' into scenarios-project-api
kdy1 633ed64
Merge remote-tracking branch 'origin/main' into scenarios-project-api
juliusmarminge 595342c
docs(scenarios): tighten the note on state made through the API
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an explicit deadline to the project mutation request.
The new
mutatecall has no deadline. The Effect fetch transport adds none. If the server accepts a mutation and stops responding, the scenario waits until the runner's 300-second timeout instead of failing after ten seconds, as the replaced CLI path did. Bound the request with the same ten-second limit. This needsDurationimported fromeffect/Durationif it is not already imported.Suggested fix