Repository navigation
fix(kiro): user and project Kiro skills show in the / and $ menus - #36200
ChristopherPHolder wants to merge 3 commits into
Conversation
Kiro reports skills only to a running session, so the composer menus on a Kiro thread never listed any. The Kiro provider now reads the folders Kiro loads skills from, `~/.kiro/skills` and the thread folder's `.kiro/skills`, when the composer asks for a folder's skills. Skills show before the first message, and project skills are scoped to their own folder. The scan follows what kiro-cli 3.1.0 advertises for the same folders: one level deep, front matter with a valid `name` and a `description`, and a project skill replacing a same-named user skill. Refs pingdotgg#31645
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Kiro's / and $ menus now list existing user and project skills using read-only, workspace-scoped discovery. The change does not automatically run skills or alter permissions or default selections. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
The automated pipeline stopped on this pull request and will not merge it: the fix is written and reviewed, but proving it needs something no worker has:
It stays open for a person to finish or close. |
With KIRO_HOME set, kiro-cli 3.1.0 lists the skills in $KIRO_HOME/skills and none from ~/.kiro/skills, so a Kiro instance with that variable showed the wrong user skills.
|
I ran these with a signed-in Kiro account (kiro-cli 3.1.0) and put the results in the description, on
One limit: I did not send a message on main; I read its "after a message" rows on the thread the branch had created. Since the first review I also pushed I use Kiro daily and have a signed-in account, so I can run whatever would help get this in: exact reproduction steps you give me, a screen recording of the flow, the raw ACP traffic, or the same checks on another kiro-cli version. Tell me what you need and I'll post the output here. |
|
+1. I hit #31645 with kiro-cli 3.3.0 on Linux, signed in with a Kiro API key, and ran some checks that may help this land. Cloud skills are missing. Kiro also advertises the account's cloud skills, with
End to end in T3. On a similar disk-scan branch, a real Kiro thread started with |
Kiro also loads the account's cloud skills, from its own copy in <kiro home>/cloud-cache/resolved/config/user/skills. Read that folder first, so a skill in ~/.kiro/skills or the workspace replaces a cloud skill of the same name, as in Kiro's list.
|
Thanks, that was a real gap. Added in ded780b: the scan now reads My account has no cloud skills, so I checked it with Could you run this branch against your 65 and say whether |
|
Note 🤖 Claude Opus 5.5 responding on behalf of @Nichokas ded780b matches Kiro on my machine (Linux, kiro-cli 3.3.0). I ran
All 65 cloud skills also exist in Your two questions:
Not checked: the |
|
Note 🤖 Claude Opus 5.5 responding on behalf of @Nichokas I ran the unverified checks from the pipeline's comment in a running build of
Not checked: |
|
@juliusmarminge the pipeline stopped here because nobody had a signed-in Kiro account. I ran those checks above, including a real message and project isolation. Is that enough to unblock it, or is something else missing? If this moves forward, I can test the implementation on a paid Kiro account (Kiro Pro, Linux, kiro-cli 3.3.0): check the values in Usage -> Limits against |





Problem
On a Kiro thread the
/and$menus list no Kiro skills (#31645). I hit this on T3 Code 0.1.9-nightly.20261111.4515 with kiro-cli 3.1.0, in a project with 54 skill folders in.kiro/skillsand 2 in~/.kiro/skills:$shows "No skills found. Try / to browse provider commands." before and after the first message. Kiro reports its skills only to a running session, and the Kiro provider publishes none of them.Change
packages/provider-kiro/src/server/skills.tsreads the folders Kiro loads skills from, with Kiro's own rules (below):~/.kiro/skills(or$KIRO_HOME/skills),<cwd>/.kiro/skills, and Kiro's local copy of the account's cloud skills in~/.kiro/cloud-cache/resolved/config/user/skills.snapshotForCwdwith that list, the same way the fx and Cursor drivers do. The composer already asks for a folder's skills through it, so nothing changes in contracts or clients.docs/user/providers-kiro.mdgets a short Skills section.Reading the folders means no Kiro session (and none of the user's MCP servers) starts for a menu, the skills show on a new thread before the first message, and a project's skills are listed only for threads in that folder.
Cloud skills were added in
ded780b9bdafter this report that an account's cloud skills were still missing. Kiro keeps them in the cache folder above and loads them from there. Two limits: the folder is where Kiro puts them, not a documented location, and the menu shows them as of Kiro's last sync on that machine, so an account that has never started a Kiro session there lists none.Relation to #31700. That PR records the skills a session advertises and publishes them on the machine snapshot. It leaves project skills out by design, because that snapshot is shared by every project, and it lists
~/.kiro/skillsonly after a Kiro session has started on the server. This PR covers both cases, so it overlaps the listing part of #31700. I did not port its$nameto/namerewrite: with kiro-cli 3.1.0 a message that starts with$db-migrationalready makes Kiro load the skill (see below).Scope
Bug fix for #31645. My comment with the project-skills case: #31645 (comment)
Verification
Everything below ran on macOS with kiro-cli 3.1.0 signed in to a Kiro account, except the one result marked as another user's.
Real app, both commits. Web dev server on an empty database, the default Kiro instance, model
claude-haiku-4.5, Full access. The projectkiro-skills-demohas three valid skills and one without a description in.kiro/skills;plain-projecthas no.kirofolder;~/.kiro/skillshas two skills.$on a new thread inkiro-skills-demo, no message senteffect-ts,effect-v3-to-v4(personal),api-review,db-migration,release-notes(project)/on the same new thread/model/modeland/skill:<name>for the same 5$on a new thread inplain-projectdb-migrationfrom$as the first message and send itSKILL.mdasks for$on that thread after the turn/on that thread after the turn/model,/side,/btw,/clear,/compact/skill:<name>for the 5On main, the last two rows were read on the thread the branch had created, after its turn had finished. I did not send a message on main.
$/The screenshots are from the first commit of this branch, "before" being the same build without the driver change. The menus in them are the ones in the table.
Kiro's rules. I started real
kiro-cli acp --agent-engine=v3 --auth-method=clisessions in probe folders and read the_meta.kiro.type: "skill"entries ofavailable_commands_update:<cwd>/.kiro/skills/<folder>/SKILL.mdorigin: "workspace",root: <cwd>~/.kiro/skills/<folder>/SKILL.mdorigin: "user"KIRO_HOMEset$KIRO_HOME/skills;~/.kiro/skillsis not read.kiro/skillsof a parent folder or the git root, with cwd below it.kiro/skills/group/<folder>/SKILL.md, a loose.md,.agents/skills,.claude/skillsname, nodescription, emptydescription, invalid YAMLUpperCase,snake_name,dot.name,has space,-leading,trailing-,double--hyphen, 65 characters,1231digit, folder name different fromname, CRLF, extra keys, no closing---, symlinked folder, symlinkedSKILL.md, hidden folder>or `namein~/.kiro/skillsand the projectnamein two project folders<kiro home>/cloud-cache/resolved/config/user/skills/<folder>/SKILL.mdorigin: "cloud",provenance.scope: "user"namein the cloud folder and in~/.kiro/skillsor the projectskillsundercloud-cache/resolved/config/organization,org,team,group,enterprise,account,workspace,project,global,shared, or directly underconfig,resolvedorcloud-cacheThe scan against Kiro. I ran the new scan over the same folders and compared its output with what Kiro advertised there, entry by entry (name, description, origin, order):
KIRO_HOMEset: identical;My account has no cloud skills, so for the cloud rows I put
SKILL.mdfiles in the cache folder of a throwawayKIRO_HOMEand started a real session against it. Another user's run, with real cloud skills. The author of that report then ran the scan fromded780b9bdon Linux with kiro-cli 3.3.0 and compared it with a real session's skill entries (their comment). This is their result, not mine:~/.kiroKIRO_HOMEwith only a copy of theircloud-cacheorigin: "cloud"All 65 of their cloud skills are under
cloud-cache/resolved/config/user/skills, and none comes from an organization. They compared the scan's output and did not open the$menu in a running build.Test.
packages/provider-kiro/src/server/skills.test.tsbuilds a home folder with user and cloud skills, a workspace with those cases, and aKIRO_HOME, and checks the lists and their order.The real-app table above was run on
f17ac58822and not repeated forded780b9bd, which only adds one more folder to the same list.In
vp run check:changed, format, lint, knip, typecheck and tests pass. Its "unused patches" step fails on my machine on an unmetunenvpeer dependency ininfra/relay, which this PR does not touch.Not checked:
organizationlayer; I don't know whether those skills land in theuserfolder or somewhere this scan does not read. The account in the run above has none.skill://resources. In the V3 engine, switching a session to an agent with"resources": []sent no new command list, so I could not see a per-agent difference to follow.