Skip to content

fix(server): ChatGPT sharing input-item rejections get their specific message #36207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cro13 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

fix(server): ChatGPT sharing input-item rejections get their specific message #36207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions apps/server/src/provider/CodexManagedErrors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ it("distinguishes unsupported tools from input items without exposing the raw re
for (const [detail, expected] of [
["tool 'namespace' is not supported", "tool namespace"],
["input item 'additional_tools' is not supported", "input item"],
[
"User subscription sharing currently supports only text, image, and file messages, item references, additional tools, compaction summaries, reasoning items, Web Search call items, developer function and custom tool call items, and programmatic tool calling items. Remove unsupported input items or use an API key instead.",
"input item",
],
]) {
const response = { error: { code, message: `${detail}; dummy-sensitive` } };
for (const value of [response, JSON.stringify(response)]) {
Expand Down
3 changes: 2 additions & 1 deletion apps/server/src/provider/CodexManagedErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ export function classifyCodexManagedError(value: unknown) {
message:
"Codex sent a tool namespace that ChatGPT sharing does not support. Use another provider for this request.",
};
if (text.includes("additional_tools"))
// ChatGPT lists `additional tools` as supported and says "Remove unsupported input items".
if (text.includes("input item"))
return {
...failure,
message:
Expand Down
Loading