Repository navigation
fix(clients): a one-hour snooze no longer reads "2h left" - #36785
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pick up the unrelated Astro check expectation fix while preserving the existing snooze label contribution unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Snooze countdown labels now use clock-minute rounding so a one-hour snooze does not appear as two hours. The change affects display text only, not snooze timing or wake behavior. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
No items needed a change. All 36 checks on PR #36785 pass at 158dab8. Macroscope approved it with no comments on lines. CodeRabbit's review says 'No actionable comments were generated' and rates the merge risk Minimal. The fix itself is unchanged: snoozeWakeLabel counts whole clock minutes (floor(wake/min) - floor(now/min), at least 1) before choosing minutes, hours or days. Retained seconds therefore no longer push a one-hour snooze up to '2h' when
nowis cut to the minute.Supersedes #29787. The change is @saphid's; their commits are kept.
Reproduction on main
Reproduced on main at cebdf39:
Evidence
Web, Chromium, 1280×800, light theme; fresh synthetic database per revision. Create a Replay showcase thread, let it finish, open Thread actions → Snooze → In 1 hour about 20 seconds into a minute. Capture immediately and after the next minute boundary.
Proven: scenarios:prove exited 0, failing on base and passing on head.
Scenario source
Base failed the expected next-minute '59m left' assertion; head passed and also satisfied the initial '1h left' assertion.
Not shown:
Tests
No new local runs this round; the code is unchanged. CI on 158dab8: all 36 checks passed. Earlier, on this head: vp test run packages/client-runtime/src/state/threadSnoozed.test.ts passed (36 tests), vp run check:changed passed, and the new test fails against main's code.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.