Skip to content

t3/try pierre diff improvements - #36994

Closed
juliusmarminge wants to merge 1 commit into
mainfrom
t3/try-pierre-diff-improvements
Closed

juliusmarminge wants to merge 1 commit into
mainfrom
t3/try-pierre-diff-improvements

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

Problem

Change

Scope

Verification

1.7.0-beta.4 ships the find, collapsed-render and hydration fixes we were
carrying in our patch. The patch keeps only the subpath exports and the
code-font remeasure. Fold state now follows Pierre's onItemCollapsedChange
instead of our onRevealSearchMatch hook.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the vouch:trusted Author is trusted by repo permissions or the VOUCHED list. label Nov 15, 2026
@juliusmarminge
juliusmarminge removed this pull request from stack #36996 November 15, 2026 00:53
@juliusmarminge

Copy link
Copy Markdown
Member Author

Opened by mistake while stacking: this branch already landed as #36974.

@github-actions github-actions Bot added the size:XL 500-999 changed lines (additions + deletions). label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 3ac364e

Macroscope's review found this PR approvable — Updates the diff viewer dependency and adapts file-folding callbacks while retaining font-layout fixes. The changes are limited to viewer behavior, with no obvious material data or operational exposure.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant