You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): allow explicit Pi models before discovery - #37058
MCP rejects an explicit Pi model with model_unavailable while Pi's inventory is still unknown and contains only default and optional custom models. It should defer validation to Pi, as it already does for empty inventories.
Reproduce on main with a subprocess fixture:
Use a Pi executable that prints pi 1.1.0 for --version and exits 1 for RPC discovery.
Call checkPiProviderStatus. It returns ready, unknown auth, and only default.
Pass that snapshot to requireAdvertisedModel with anthropic/claude-opus. It rejects the model before Pi can validate it.
Change
Treat Pi's placeholder inventory like an empty inventory only while auth is unknown and no discovered model exists. Keep strict validation after discovery or a known auth result, and leave other providers unchanged.
Scope
This is a two-file fix to the existing validator with six regression cases, so it uses the small, obvious bug-fix exception without a separate issue. #28557 fixes one discovery failure; this covers validation when discovery still fails.
Verification
On main 015eba4083974f8ed86694a8770a4311d8a4714b, the regression cases produced 3 failures and 3 passes. With the fix, all 6 passed. The subprocess fixture changed from model_unavailable to accepted with the same fallback snapshot.
Both focused files passed: 94 tests in OrchestratorMcpService.test.ts and 21 in Pi's status.test.ts. Server typecheck, lint and the two-file format check passed. check:changed also passed.
The previous full server-suite run on macOS had 15 failures outside the changed file: 14 also failed on unmodified main, and one timeout passed in isolation; I did not rerun the full suite. No real Pi login, UI flow, or paid turn was exercised.
Macroscope's review found this PR approvable — Explicit Pi model requests can proceed before model discovery completes, while discovered inventories retain validation. Default model selection and provider availability checks remain unchanged.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
requireAdvertisedModel now accepts unadvertised slugs for empty inventories and for Pi providers with unknown authentication when no non-custom model has a subProvider. Tests cover these cases and rejection cases.
Changes: Pi model resolution
Layer / File(s)
Summary
Pi provider acceptance rule apps/server/src/mcp/OrchestratorMcpService.ts, apps/server/src/mcp/OrchestratorMcpService.test.ts
requireAdvertisedModel permits unadvertised slugs for qualifying Pi providers. Tests cover acceptance before discovery and rejection after discovery, for unauthenticated Pi, and for another provider.
Explicit Pi models are now accepted before model discovery, and validation stays strict after discovery or once authentication is known. The change is narrow, other providers are unaffected, and it is covered by tests, so no merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(server): allow explicit Pi models before discovery" names the main change: MCP now accepts explicit Pi model slugs while Pi's placeholder inventory is unknown. It matches the raw summar…
Description check
The description follows the template's main sections: Problem, Change, Scope, and Verification. The Problem section gives the expected behavior and reproduction steps. The Change section explains the …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(server): allow explicit Pi models before discovery" names the main change: MCP now accepts explicit Pi model slugs while Pi's placeholder inventory is unknown. It matches the raw summary, which describes the requireAdvertisedModel change for Pi with unknown auth, and the PR objectives. It uses a conventional commit format and is 54 characters long.
Full details: Description check
Explanation
The description follows the template's main sections: Problem, Change, Scope, and Verification. The Problem section gives the expected behavior and reproduction steps. The Change section explains the fix and limits it to Pi unknown-auth placeholder inventories. The Scope section explains why no issue is linked, and the Verification section gives focused test results and states what was not checked. The description does not link an issue, but it gives a reason for omitting one, as the template allows for small obvious bug fixes. The template's agent-model line is present as an attribution sentence ("Created with GPT-6.1 Sol in Pi via T3 Code."), so that item is covered too.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
With discovery failing and only Pi default advertised, submitted identical requests to delegate once to Pi using anthropic/claude-haiku-5-5. Base rejected the model before launch; head ran the child successfully and returned hello.
Environment: Linux, Chromium web client, dark theme, 1440×1000 CSS viewport, fresh isolated databases and synthetic project data. Real Pi agents; discovery failure induced by a wrapper, matching the triage caveat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).takeover:needs-juliusTakeover done; route gate says Julius decidesvouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
juliusmarminge
added
the
takeover:in-progress
Problem
MCP rejects an explicit Pi model with
model_unavailablewhile Pi's inventory is still unknown and contains onlydefaultand optional custom models. It should defer validation to Pi, as it already does for empty inventories.Reproduce on main with a subprocess fixture:
pi 1.1.0for--versionand exits 1 for RPC discovery.checkPiProviderStatus. It returnsready, unknown auth, and onlydefault.requireAdvertisedModelwithanthropic/claude-opus. It rejects the model before Pi can validate it.Change
Treat Pi's placeholder inventory like an empty inventory only while auth is unknown and no discovered model exists. Keep strict validation after discovery or a known auth result, and leave other providers unchanged.
Scope
This is a two-file fix to the existing validator with six regression cases, so it uses the small, obvious bug-fix exception without a separate issue. #28557 fixes one discovery failure; this covers validation when discovery still fails.
Verification
On main
015eba4083974f8ed86694a8770a4311d8a4714b, the regression cases produced 3 failures and 3 passes. With the fix, all 6 passed. The subprocess fixture changed frommodel_unavailableto accepted with the same fallback snapshot.Both focused files passed: 94 tests in
OrchestratorMcpService.test.tsand 21 in Pi'sstatus.test.ts. Server typecheck, lint and the two-file format check passed.check:changedalso passed.The previous full server-suite run on macOS had 15 failures outside the changed file: 14 also failed on unmodified main, and one timeout passed in isolation; I did not rerun the full suite. No real Pi login, UI flow, or paid turn was exercised.
Created with GPT-6.1 Sol in Pi via T3 Code.