Skip to content

Adds release of Authors History plugin. Compatible with 3.5. - #545

Merged
bozana merged 3 commits into
pkp:mainfrom
lepidus:port-authorsHistory-3_5_0
Oct 6, 2026
Merged

bozana merged 3 commits into
pkp:mainfrom
lepidus:port-authorsHistory-3_5_0

Conversation

@YvesLepidus

@YvesLepidus YvesLepidus commented Sep 18, 2026 •

Copy link
Copy Markdown

Signed-off-by: yves <yves@lepidus.com.br>
@bozana

bozana commented Sep 24, 2026

Copy link
Copy Markdown

Hi @YvesLepidus, really nice to see the new backend-UI approach here, with your own Vue components!

One thing on AuthorsHistoryController: it authorizes by role+context (roleAuthorizer) but not per-submission, so a section editor could read any submission's author data in the journal. Adding SubmissionAccessPolicy in authorize() fixes that — it checks the submission exists, is in the context, and that the user may actually access this submission (e.g. a sub-editor must be assigned to it), while managers/admins keep full access:

public function authorize(PKPRequest $request, array &$args, array $roleAssignments): bool
{
    $this->addPolicy(new SubmissionAccessPolicy($request, $args, $roleAssignments));
    return parent::authorize($request, $args, $roleAssignments);
}

It reads submissionId from the query, so no route change needed — and it lets you drop the manual context check.

Would you like to add this before merge?
Thanks a lot!

@YvesLepidus

Copy link
Copy Markdown
Author

Hi, @bozana

Many thanks!

I want to update it before the merge.

I'll let you know here when I have the updated release :)

Signed-off-by: yves <yves@lepidus.com.br>
@YvesLepidus

Copy link
Copy Markdown
Author

Hi, @bozana

The new release 3.0.0.2 is now in this PR. It adds SubmissionAccessPolicy to the authors history endpoint, as you suggested.

Thanks again for the review!

@bozana

bozana commented Oct 2, 2026 •

Copy link
Copy Markdown

Hi @YvesLepidus, great!
Just one small thing: Could you please remove 3.0.0.1 release from the gallery? -- 3.0.0.1 was never published in the gallery and we usually add only the latest version, so there's no need to add it.
Thanks a lot!

Signed-off-by: yves <yves@lepidus.com.br>
@YvesLepidus

Copy link
Copy Markdown
Author

Hi, @bozana

Done! I removed the 3.0.0.1 release, so now this PR only adds 3.0.0.2.

@bozana
bozana merged commit 3fba1c1 into pkp:main Oct 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants