Add move-tables start and stop commands - #1437
Closed
no-itsbackpack wants to merge 1 commit into
Closed
no-itsbackpack wants to merge 1 commit into
no-itsbackpack wants to merge 1 commit into
Conversation
Wire `pscale branch vtctld move-tables start` and `stop` to the existing vtctld workflow start/stop endpoints, using the same --workflow and --target-keyspace flags as the other move-tables commands. Co-authored-by: Gomez <no-itsbackpack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
MoveTables workflows can be created with
--auto-start=false, stop after copy, or be paused later. Those workflows had nomove-tablessubcommands to start or stop them; operators had to use the genericvtctld start-workflow/stop-workflowcommands with a different flag shape.Solution:
Add
pscale branch vtctld move-tables startandmove-tables stop. Both take--workflowand--target-keyspace, matching the other MoveTables commands, and call the existing workflow start/stop API.statusnow suggestsstartwhen every stream is stopped.create --auto-start=falsesuggestsstartas the next step.Security impact:
None. These commands call existing authenticated start/stop endpoints and do not change authorization or expand access.
Testing:
go test ./internal/cmd/branch/vtctld/... ./internal/planetscale/...Slack Thread