Sanitization: Harden placeholder parsing - #218
Merged
Merged
Conversation
Scan SQL lexical context before substituting placeholders so markers inside literals and non-executable comments are left alone, and reject values that cannot be formatted safely. Co-authored-by: Cursor <cursoragent@cursor.com>
no-itsbackpack
requested review from
a team and
mattrobenolt
as code owners
September 23, 2026 16:49
joshmgross
approved these changes
Sep 23, 2026
dgraham
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
//line comments and defensively treat form feed or vertical tab after--as comment whitespace, preventing scanner desynchronization across tokenizer variants./*! ... */comments while failing closed where Vitess 23 and 24 tokenize the body differently. Split injected/*and*/pairs across adjacent literals, including overlapping delimiters.ASbefore quoted select-list aliases whose text could concatenate with a quoted value.Why
Blind placeholder replacement can consume markers from SQL literals, comments, or variable names and then place attacker-controlled values into executable SQL. It can also change the tokenization of a valid bind marker when the formatted value touches a comment version, variable, alias, or operator. The formatter must follow the supported Vitess lexical boundaries and reject cases whose meaning cannot be preserved safely.