fix: max_score when used with full_score - #1
Merged
Merged
Conversation
piki
approved these changes
Sep 17, 2026
eeeebbbbrrrr
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max_score()used the regular scoring policy even when paired withfull_score(). Frequent terms and scoring stop words could therefore contribute to the numerator but not the denominator, producing incorrect normalization or a zero maximum.Make
max_score()use full scoring when a correspondingfull_score()appears in the same query level.Add a regression test covering both operand orders and a
max_score() > 0filter.