Repository navigation
feat(verify): cover BrushDescriptor in verify-brushkit and fix map drift - #285
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance pass on the
verify-brushkitskill. Every feature file was checked against source and driven live through the probe, on the fuzz seeds and on the local corpus (140.abr, 211.brushset, 25.brush). No exit 101 in any of the 516 sweep runs.Changes
New feature: brush descriptor. The typed
BrushDescriptoron sampled brushes and computed presets had no feature file and no probe output.parsenow writes each descriptor as itsDebugtext, because the type has no serde derive. The newfeatures/brush-descriptor.mdcovers the seed values, default descriptors, mode parity, tool options, gating and the fourcorpus_smokedescriptor tests.Computed tip size. The computed seed preset (30 px diameter) is now 36x36 and
synthesized_sideis 36, not 32. The falloff past the nominal edge (fix(preview): keep Photoshop's soft falloff past a computed tip's nominal edge #265 to fix(preview): keep a computed tip's ink continuous across diameter 2 px #278) widened it.Corpus claims. The corpus now holds:
UnsupportedTipKindwith aTipShapename.brushfilesNonzero dual-brush drops appear in v6, v9 and v10 packs (up to 34), not in the one v7 pack. On every pack,
up_front_decoded_lenis at least the dropped tips' pixel sum, but it is rarely equal to it.Budget. No corpus pack holds more than 256 MiB of tip pixels (the largest holds about 115 MB), so
OverBudgetcannot be reached on real files. The recipe now names that precondition and points at the budget tests.Smaller wording fixes.
.brushseterror conditionsall-deferredreports v1/v2 up-front bytesstop5recipe needs a pack with more than 5 entriesEvidence
Every changed recipe was re-run with the changed probe. Real-file evidence below is text only.
tool_optionsmatches the dump'stoolOptionsclass on 52 of 52. All 27 presets withuseTipDynamicsfalse have the Shape Dynamics fieldsNone.cargo test -p brushkit-abr --test corpus_smokewith the four descriptor tests: 4 passed.