Repository navigation
perf(convert): improve performance by prioritizing typed arrays - #71
Merged
Merged
Conversation
… bytes - Ignore a UTF-8 continuation byte without a lead byte - Convert values above U+10FFFF to the fallback character when converting to UTF-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved conversion performance by prioritizing typed arrays.
This makes
convert()about 1.5-3.5x faster for most encoding pairs (about 1.3x when converting from UTF-8) and reduces peak memory during conversion by about 25-60%.A plain
Arrayis still used when typed arrays are not available, or when the output length cannot be determined in advance (e.g., with the{ fallback: "html-entity" }option).Fixes
0x80-0xBF) without a lead byte is now ignored.undefinedelement.Benchmark
Node.js v24 with the full text of "I Am a Cat" (about 350,000 characters),
type: 'array'(ops/sec, higher is better):Peak memory (maxRSS) while repeating the same conversion 20 times (lower is better):