Repository navigation
refactor(actor)!: Remove the unused global socket timeout - #948
Merged
Merged
Conversation
Remove the unused timeout parameter from `SocketInterface`. Update actors to not use the global `timeout` parameter. Per-call receive timeouts and lifecycle waits remain unchanged. BREAKING CHANGE: `SocketInterface`, `Actor`, `DispatcherActor`, and `ProcessorActor` classes no longer accept a timeout constructor argument.
Use infinite linger on proxy control sockets so closing a proxy immetiadly after sending a poison pill does not discard the pending messages.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
==========================================
- Coverage 86.73% 86.72% -0.02%
==========================================
Files 81 81
Lines 2820 2817 -3
==========================================
- Hits 2446 2443 -3
Misses 374 374
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR overview:
SocketInterfaceand actor classes.Breaking changes:
SocketInterface,Actor,DispatcherActor, andProcessorActorno longer accept a constructortimeoutargument.