Skip to content

chore: sync development into main for v2.28.1 release #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prabothcharith merged 2 commits into from
Oct 28, 2026
Merged

chore: sync development into main for v2.28.1 release #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56b0b17
test(browser): tolerate subpixel precision in 44px touch target checks
prabothcharith Oct 28, 2026
3be3a19
Merge pull request #175 from prabothcharith/fix/subpixel-touch-target
prabothcharith Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/browser/widget.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,8 +1771,8 @@ test("A11Y-501: full supported matrix verification - zoom reflow, forced-colors,
});
await expect(trigger).toBeVisible();
const triggerBox = await trigger.boundingBox();
expect(triggerBox!.width).toBeGreaterThanOrEqual(44);
expect(triggerBox!.height).toBeGreaterThanOrEqual(44);
expect(Math.round(triggerBox!.width)).toBeGreaterThanOrEqual(44);
expect(Math.round(triggerBox!.height)).toBeGreaterThanOrEqual(44);

// Open panel under forced-colors
await trigger.click();
Expand All @@ -1793,13 +1793,13 @@ test("A11Y-501: full supported matrix verification - zoom reflow, forced-colors,
);
expect(noHorizontalOverflow).toBe(true);

// 3. Touch target sizing verification: every visible interactive button >= 44x44px
// 3. Touch target sizing verification: every visible interactive button >= 44x44px (with subpixel tolerance)
const visibleButtons = await panel.locator("button:visible").all();
for (const btn of visibleButtons) {
const box = await btn.boundingBox();
if (box && box.width > 0 && box.height > 0) {
expect(box.width).toBeGreaterThanOrEqual(44);
expect(box.height).toBeGreaterThanOrEqual(44);
expect(Math.round(box.width)).toBeGreaterThanOrEqual(44);
expect(Math.round(box.height)).toBeGreaterThanOrEqual(44);
}
}

Expand Down