Repository navigation
Rotate idempotency key when we've gotten a 40x error on upload - #102
Merged
Merged
Conversation
robbi5
changed the title
robbi5
commented
Oct 8, 2026
| if (response.getResponse().code() >= 400) { | ||
| sentry.captureException(new ApiException("Received response (" + response.getResponse().code() + ") for queued call: " + response.getData().toString())); | ||
| // We ignore 400s, because we can't do something about them | ||
| db.getQueuedCallQueries().updateIdempotencyKey(NonceGenerator.nextNonce(), call.getId()); |
Member
Author
There was a problem hiding this comment.
I'm not really sure about that one. postResource should throw some Exception, so that whole if shouldn't really be executed.
robbi5
force-pushed
the
rotate-idempotency-key-40x
branch
from
October 9, 2026 08:24
e20fc7d to
7afc9ec
Compare
robbi5
marked this pull request as ready for review
October 9, 2026 08:25
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
============================================
+ Coverage 30.09% 32.36% +2.27%
- Complexity 548 584 +36
============================================
Files 145 147 +2
Lines 7507 8176 +669
Branches 1035 1112 +77
============================================
+ Hits 2259 2646 +387
- Misses 4948 5213 +265
- Partials 300 317 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pc-coholic
approved these changes
Oct 12, 2026
Member
|
Tested by removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.