chore(deps): @prisma/management-api-sdk 1.69.0 -> 1.79.0 - #290
Conversation
The engine, @prisma/cli and prisma pins move together, because the engine's types refer to the SDK's types and two copies fail to typecheck against each other. The engine's version stays at 0.6.1: only its devDependencies changed, and npm does not publish those. The SDK now types credential.type in the GET /v1/me response as string, so AuthCredential.type becomes string. Nothing in the CLI branches on its value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe management API SDK dependency was upgraded from version 1.69.0 to 1.79.0 in three package manifests. The AuthCredential.type declaration now accepts any string instead of only "oauth", "service_token", or "management_token". Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The SDK update resolves consistently, and the credential type matches the updated API. No concrete behavior regression is established; the change appears ready to merge with normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The credential type now accepts more values, but the inspected authentication flow does not use that value to grant access. Upstream response validation and all downstream consumers remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
@prisma/composer declares the SDK as ^1.76.0, and the lockfile had kept its older resolution, 1.76.0, next to the CLI's 1.79.0. pnpm dedupe moves Composer's copy to 1.79.0, so the lockfile holds one SDK version. The same run merged duplicate copies of semver and string-width. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Moves
@prisma/management-api-sdkfrom1.69.0to1.79.0, the version npm'slatesttag points to. No release and no other dependency changes.Changes
packages/cli-engine(devDependencies),packages/cliandpackages/prisma(dependencies). The engine's types refer to the SDK's types. If the engine and the CLI pin different versions, pnpm installs both and the CLI fails to typecheck against the engine.0.6.1: only itsdevDependencieschanged, and npm does not publish those. Its peer range^1.55.0already admits1.79.0.node scripts/check-engine-version.mjs origin/mainreports the version as consistent.AuthCredential.typeis nowstringinpackages/cli/src/types/auth.ts. The SDK changedcredential.typein theGET /v1/meresponse from"oauth" | "service_token" | "management_token"tostring. Nothing in the CLI or the engine branches on its value;packages/cli/src/auth/operations.tspasses the credential through unchanged.Every other SDK type change between the two versions is an addition: new endpoints and new optional fields.
Notes
@prisma/composer@0.23.0declares the SDK as^1.76.0, and the lockfile had kept that older resolution.pnpm dedupemoved it to1.79.0. The same run merged duplicate copies ofsemverandstring-width.prismatests, grammar and conformance checks. The end-to-end suite did not run locally, because noPRISMA_E2E_SERVICE_TOKENwas set. CI runs it.🤖 Generated with Claude Code