Repository navigation
fix: don't create an artifact storage record for the image attestation - #4
Merged
Merged
Conversation
The attest action creates a storage record by default, which needs artifact-metadata: write from every caller. We don't use storage records, so every run ended with a warning. The attestation itself is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/attest-build-provenancecreates an artifact storage record by default when it pushes to a registry. That needsartifact-metadata: write, which none of the callers grant, so every Delivery run ended with "Failed to create storage record". We don't use storage records, sodocker-publish.ymlnow setscreate-storage-record: false. The provenance attestation itself is unchanged.The alternative was asking every caller for
artifact-metadata: write. With callers on the moving@v1tag, that would have broken every caller that doesn't grant it.CHANGELOG: v1.1.2.
Part of YIV-401.