Repository navigation
Update rooms that get left, fix restored invites, respect can-send/react permissions - #1365
Merged
Merged
Conversation
…act perms we now maintain the room membership state of every open room in order for any screen to be able to figure out why a room isn't loaded (e.g., after being restored). When we leave a room that's open, or get kicked or banned from it, the input bar now shows a new `RoomMembershipFooter` widget (kinda like the tombstone footer) that explains what happened and no longer lets you hopelessly send invalid messages into a void room. It also shows buttons for re-joining (or knocking, etc) based on the join rule. we still let you view the timeline, but you can't reply, react, edit, pin, delete, invite, etc. We also don't send read receipts or load history, mostly because none of that works in a room you're not in. Re-joining or leaving works transparently without killing the roomscreen instance. Similarly, an InviteScreen whose invite was accepted, rejected, or otherwise "recanted" no longer just spins infinitly after being restored. If it was an invite to a space that got joined elsehwere, it gets converted into a Space Lobby Screen, and similarly for room screens. If the invite was rejected, it says why. An extension of those changes are that we now: * check permissions for sending messages before enabling reply/edit. * Reactions check permissions too, and show an error explaining why they cannot be sent instead of silently doing nothing. * An in-progress edit that the homeserver rejects is restored back into the EditingPane so that you don't lose your changed draft. That was annoying me. Fixes project-robius#656. Fixes project-robius#1050.
Upstream removed `invited_room_info()` and inlined its list of via servers into `add_new_room()`, so we drop that function and have `add_new_room()` use the shared `via_servers()` helper instead.
kevinaboos
added a commit
that referenced
this pull request
Nov 12, 2026
Fix layout a bit too, things weren't perfectly vertically centered. WE also clarify how an invite was ended (either here or elsewhere). Follow-up to #1365.
kevinaboos
added a commit
that referenced
this pull request
Nov 12, 2026
…ites A footer could've squeezed the EditingPane out of view in a really short view, but that's now fixed. If an invite was recalled or otherwise ended, it now says who ended it and why (the reason). Cached memberships are cleared when the session token expires. Follow-up to #1365.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we now maintain the room membership state of every open room in order for any screen to be able to figure out why a room isn't loaded (e.g., after being restored).
When we leave a room that's open, or get kicked or banned from it, the input bar now shows a new
RoomMembershipFooterwidget (kinda like the tombstone footer) that explains what happened and no longer lets you hopelessly send invalid messages into a void room. It also shows buttons for re-joining (or knocking, etc) based on the join rule.we still let you view the timeline, but you can't reply, react, edit, pin, delete, invite, etc. We also don't send read receipts or load history, mostly because none of that works in a room you're not in. Re-joining or leaving works transparently without killing the roomscreen instance.
Similarly, an InviteScreen whose invite was accepted, rejected, or otherwise "recanted" no longer just spins infinitly after being restored. If it was an invite to a space that got joined elsehwere, it gets converted into a Space Lobby Screen, and similarly for room screens. If the invite was rejected, it says why.
An extension of those changes are that we now:
Fixes #656.
Fixes #1050.