Repository navigation
Don't ever cut off the room input bar's text input - #1366
Merged
Merged
Conversation
THe old way of capping every subview in the room input bar at 75% of the room screen's height was good in all cases except super long text AND something else atop it, like a reply preview or warning banner. If those also appeared then it could push the bottom of the text input below the screen. We now reserve one full line for text input at a bare minimum, and then use the remaining space (`Unused`) to lay out the views above it. This includes the warning banners, so we move them into the input bar so they will always ben shown in full. THe third priority is the reply preview, which is now collapsed to fit the remaining height. we also save a bit more vertical space by placing the user avatar and display name of the replied-to message right next to the "Replying to:" header, but allow them to wrap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THe old way of capping every subview in the room input bar at 75% of the room screen's height was good in all cases except super long text AND something else atop it, like a reply preview or warning banner. If those also appeared then it could push the bottom of the text input below the screen.
We now reserve one full line for text input at a bare minimum, and then use the remaining space (
Unused) to lay out the views above it. This includes the warning banners, so we move them into the input bar so they will always ben shown in full.THe third priority is the reply preview, which is now collapsed to fit the remaining height.
we also save a bit more vertical space by placing the user avatar and display name of the replied-to message right next to the "Replying to:" header, but allow them to wrap.