Repository navigation
Conversation
kblaschke
approved these changes
Nov 1, 2026
kblaschke
left a comment
kblaschke
left a comment
Member
There was a problem hiding this comment.
Uh, those nasty locales...
Thanks for the heads-up!
lstrsrt
force-pushed
the
stof-locale-fix
branch
from
November 1, 2026 17:23
53afdc4 to
6f4b936
Compare
Author
|
Oops, I initialized the stringstream with |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the preset parser. The bug also existed in the previous parser where someone else noticed and fixed it but the fix wasn't brought over to the new one. In short,
GetFloatcallsstd::stofwhich callsstrtof. This is a locale-dependent function so when using a locale that defines the decimal point to be a comma (like German or Czech), incorrect values will be returned. For example "0.8" just becomes 0 which obviously breaks a ton of stuff. Fix is the same as before: just use a stringstream imbued with a C locale.