Repository navigation
fix(analytics): exclude codecov-commenter from contributor metrics - #1602
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 |
There was a problem hiding this comment.
Summary: This change adds the Codecov comment bot to the list of automated accounts that the contributor metrics ignore, so it stops appearing as a human contributor. I checked that the metrics generator actually uses this list and rebuilds the data from scratch each run, so the stale entry will disappear on the next refresh as the PR says. One small gap: the test that lists every recognized bot was not updated to include the new one.
correctness
- (low, in-scope)
scripts/contributor-tracker.test.js:16-38enumerates every entry inBOT_PATTERNSby name; the new/^codecov-commenter$/i(scripts/lib/contributor-tracker.mjs:35) has no corresponding case. Add"codecov-commenter"to that array so a future edit that drops or loosens the pattern is caught. VerifiedisBotis the filter used by the generator (scripts/fetch-contributor-metrics.js:54,70) and thataggregateContributionsrebuildspeoplefrom all events, so the existing entry atstatic/data/contributor-metrics.json:2255will drop on the next successful refresh. - (low, out-of-scope)
scripts/fetch-contributors.js:21andscripts/fetch-hive-history.js:120keep separateBOT_LOGINSlists that do not includecodecov-commenter; those feed other pages and may still show the bot. Backlog, not this PR.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
|
Reviewed: a one-line change adding |
Summary: The contributor metrics still listed the Codecov comment bot as a contributor, even though known bots are meant to be excluded. This change teaches the bot filter to recognize it. The next analytics refresh will drop the existing entry from the data.
Adds
/^codecov-commenter$/itoBOT_PATTERNSinscripts/lib/contributor-tracker.mjs. The generatedstatic/data/contributor-metrics.jsonis intentionally untouched; the analytics refresh workflow regenerates it and will drop thecodecov-commenterentry.Closes #1601
— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88