Skip to content

fix(analytics): exclude codecov-commenter from contributor metrics - #1602

Merged
Danathar merged 1 commit into
mainfrom
scanner/fix-1601
Oct 26, 2026
Merged

Danathar merged 1 commit into
mainfrom
scanner/fix-1601

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary: The contributor metrics still listed the Codecov comment bot as a contributor, even though known bots are meant to be excluded. This change teaches the bot filter to recognize it. The next analytics refresh will drop the existing entry from the data.


Adds /^codecov-commenter$/i to BOT_PATTERNS in scripts/lib/contributor-tracker.mjs. The generated static/data/contributor-metrics.json is intentionally untouched; the analytics refresh workflow regenerates it and will drop the codecov-commenter entry.

Closes #1601

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive
hivecommons-hive Bot requested a review from castrojo as a code owner October 25, 2026 14:41
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: 25b83a0

— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary: This change adds the Codecov comment bot to the list of automated accounts that the contributor metrics ignore, so it stops appearing as a human contributor. I checked that the metrics generator actually uses this list and rebuilds the data from scratch each run, so the stale entry will disappear on the next refresh as the PR says. One small gap: the test that lists every recognized bot was not updated to include the new one.


correctness

  • (low, in-scope) scripts/contributor-tracker.test.js:16-38 enumerates every entry in BOT_PATTERNS by name; the new /^codecov-commenter$/i (scripts/lib/contributor-tracker.mjs:35) has no corresponding case. Add "codecov-commenter" to that array so a future edit that drops or loosens the pattern is caught. Verified isBot is the filter used by the generator (scripts/fetch-contributor-metrics.js:54,70) and that aggregateContributions rebuilds people from all events, so the existing entry at static/data/contributor-metrics.json:2255 will drop on the next successful refresh.
  • (low, out-of-scope) scripts/fetch-contributors.js:21 and scripts/fetch-hive-history.js:120 keep separate BOT_LOGINS lists that do not include codecov-commenter; those feed other pages and may still show the bot. Backlog, not this PR.

No findings from: security, intent-alignment, style, docs-currency.

Confidence: 5/5 (safe)

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@Danathar

Copy link
Copy Markdown
Contributor

Reviewed: a one-line change adding codecov-commenter to the bot patterns excluded from contributor metrics. Adding it to the merge queue.

@Danathar
Danathar added this pull request to the merge queue Oct 26, 2026
Merged via the queue into main with commit 4f96a58 Oct 26, 2026
11 checks passed
@Danathar
Danathar deleted the scanner/fix-1601 branch October 26, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (intent-alignment): codecov-commenter still listed despite 'known bots excluded' claim

1 participant