chore: rephrase docs to block all openshift label mutations by users - #136
Open
sandert-k8s wants to merge 1 commit into
Open
chore: rephrase docs to block all openshift label mutations by users#136sandert-k8s wants to merge 1 commit into
sandert-k8s wants to merge 1 commit into
Conversation
✅ Deploy Preview for docs-projectcapsule ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sandert-k8s
marked this pull request as ready for review
September 11, 2026 13:52
sandert-k8s
force-pushed
the
docs-openshift-bypass-scc
branch
from
September 11, 2026 13:52
87c0234 to
2ec2ff6
Compare
Signed-off-by: sandert-k8s <sandert98@gmail.com>
sandert-k8s
force-pushed
the
docs-openshift-bypass-scc
branch
from
September 11, 2026 13:54
2ec2ff6 to
02bc64c
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The OpenShift example contains two unresolved critical issues that prevent the documented protections from working.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates OpenShift documentation to describe protecting namespace metadata from CapsuleUsers.
Changes:
- Rephrases the security release note.
- Expands the OpenShift metadata-protection example.
- Adds guidance for labels, annotations, and pod-security metadata.
File summaries
| File | Summary |
|---|---|
content/en/docs/whats-new.md |
Updates the security release note. |
content/en/docs/operating/setup/openshift.md |
Adds the metadata-protection example. Two critical findings remain: the metadata key is treated literally and lacks regex support (3 votes), and the deny entry lacks the required values matcher (2 votes). One capitalization nit remains (1 vote). |
Review details
Suppressed comments (3)
content/en/docs/operating/setup/openshift.md:151
- The annotation key is written as a regex too, but metadata rules do not support regex matching for annotation names. Therefore
openshift.io/sa.scc.uid-rangewill not be covered by this example, despite the warning saying it must not be user-modifiable. Enumerate the sensitive annotation keys or use a legacy/secondary admission policy.
".*openshift.io/.*":
content/en/docs/operating/setup/openshift.md:154
- This annotation deny entry also omits the
valuesmatcher. Since deny rules match configured values,required: falsedoes not make this a presence-only deny; add an all-values matcher so changes topod-security.kubernetes.io/enforceare actually blocked.
"pod-security.kubernetes.io/enforce":
required: false
content/en/docs/operating/setup/openshift.md:158
OpenShiftis the product name, so the alert title should use the established capitalization rather thanopenshift.
{{% alert title="Block openshift labels and annotations" color="warning" %}}
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.