Skip to content

chore: rephrase docs to block all openshift label mutations by users - #136

Open
sandert-k8s wants to merge 1 commit into
projectcapsule:mainfrom
sandert-k8s:docs-openshift-bypass-scc
Open

chore: rephrase docs to block all openshift label mutations by users#136
sandert-k8s wants to merge 1 commit into
projectcapsule:mainfrom
sandert-k8s:docs-openshift-bypass-scc

Conversation

@sandert-k8s

Copy link
Copy Markdown
Collaborator

No description provided.

@netlify

netlify Bot commented Sep 11, 2026

Copy link
Copy Markdown

Deploy Preview for docs-projectcapsule ready!

Name Link
🔨 Latest commit 02bc64c
🔍 Latest deploy log https://app.netlify.com/projects/docs-projectcapsule/deploys/6aa40802fc8086000820272b
😎 Deploy Preview https://deploy-preview-136--docs-projectcapsule.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sandert-k8s
sandert-k8s marked this pull request as ready for review September 11, 2026 13:52
@sandert-k8s
sandert-k8s force-pushed the docs-openshift-bypass-scc branch from 87c0234 to 2ec2ff6 Compare September 11, 2026 13:52
@sandert-k8s
sandert-k8s requested a lite review from Copilot September 11, 2026 13:52
Signed-off-by: sandert-k8s <sandert98@gmail.com>
@sandert-k8s
sandert-k8s force-pushed the docs-openshift-bypass-scc branch from 2ec2ff6 to 02bc64c Compare September 11, 2026 13:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The OpenShift example contains two unresolved critical issues that prevent the documented protections from working.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates OpenShift documentation to describe protecting namespace metadata from CapsuleUsers.

Changes:

  • Rephrases the security release note.
  • Expands the OpenShift metadata-protection example.
  • Adds guidance for labels, annotations, and pod-security metadata.
File summaries
File Summary
content/en/docs/whats-new.md Updates the security release note.
content/en/docs/operating/setup/openshift.md Adds the metadata-protection example. Two critical findings remain: the metadata key is treated literally and lacks regex support (3 votes), and the deny entry lacks the required values matcher (2 votes). One capitalization nit remains (1 vote).
Review details

Suppressed comments (3)

content/en/docs/operating/setup/openshift.md:151

  • The annotation key is written as a regex too, but metadata rules do not support regex matching for annotation names. Therefore openshift.io/sa.scc.uid-range will not be covered by this example, despite the warning saying it must not be user-modifiable. Enumerate the sensitive annotation keys or use a legacy/secondary admission policy.
              ".*openshift.io/.*":

content/en/docs/operating/setup/openshift.md:154

  • This annotation deny entry also omits the values matcher. Since deny rules match configured values, required: false does not make this a presence-only deny; add an all-values matcher so changes to pod-security.kubernetes.io/enforce are actually blocked.
              "pod-security.kubernetes.io/enforce":
                required: false

content/en/docs/operating/setup/openshift.md:158

  • OpenShift is the product name, so the alert title should use the established capitalization rather than openshift.
{{% alert title="Block openshift labels and annotations" color="warning" %}}
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread content/en/docs/operating/setup/openshift.md
Comment thread content/en/docs/operating/setup/openshift.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants