Repository navigation
fix(ci): main's lint and tests pass again - #54
Merged
Merged
Conversation
Main's CI failed on every push. Lint found 54 errors in fork code, all from upstream lint rules that arrived with the 0.0.76 sync. 6 tests in scripts/mobile-native-client.test.ts failed on CI's x64 runners, because the fork's test reached upstream's Apple-silicon check without pinning the host. - Delete the comments the comment rule rejects, rather than trim them. - Delete issueProviderRequirement, which nothing ever called. - State the reason on effects that hold native, DOM or server resources. Direct push reads environments through useEffectEvent, so its effects depend only on the signals that re-run them. - Drop IssuesPanel's manual memos; the React Compiler memoizes it. - Move 2 browser tests onto the shared render helper. - Replace the em dash in the attention notification title. - Pin arm64 in the native-client test, as it already pins darwin. - sync-upstream now runs the whole-repo lint and requires CI to pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's CI failed on every push. 2 jobs caused it:
scripts/mobile-native-client.test.tshit upstream's Apple-silicon check on CI's x64 runners. They pass on an arm64 Mac, which is why the local suites missed them.Fixes:
issueProviderRequirementinpackages/contracts/src/issue.ts. Nothing has called it since it was added.environmentsthroughuseEffectEvent, so its effects depend only on the signals that re-run them.RightPanelTabsandSourceClearCooldownuse the sharedrenderhelper.vp run lint), and a sync PR's CI must pass.Proof:
vp run lint: exits 0. The 3 warnings left are in files identical to upstream.vp run check:changed: format, lint, knip, typecheck (32 packages) and 76 tests pass.DirectPush.statusandDirectPush.unregister, both successful.Not covered: the Mobile Native Static Analysis job on main was cancelled because GitHub had no macOS runner ("not acquired by Runner"). A rerun is the fix if it happens here.
🤖 Generated with Claude Code
Model: Claude Opus 5.5, harness: Claude Code in PseudoCode