[ptr727]

Summary

Review on the promotion pull request #1234 found that track_differences read a missing dump as an empty track list. So a file whose dump held no tracks in one run, and that had no dump in the other, compared equal, and the comparison passed with no track evidence for it.

• A file one run dumped and the other did not now fails, naming the run without a dump.
• Two runs that both dumped no tracks for a file still match.
• RegressionTests/README.md "Comparing two runs" states the case.

A file absent from both runs' dumps is not compared for tracks, and its outcome still is. The regression corpus holds no sidecar files, so every processed file is read from its tools and logs a dump.

Test plan

• python3 -m unittest discover -s tests in RegressionTests/: 94 tests pass. test_dump_on_one_side_only_fails covers both directions and fails without the fix.
• uvx ruff@0.17.3 check ., uvx ruff@0.17.3 format --check ., uvx mypy@latest, and prose_lint.py --diff origin/develop: clean.

🤖 Generated with Claude Code

[ptr727]

A recorded local strict-review pass covers head 657880dbb5a5c3efb9f03d3f59a7e1b99767cb5f, the content this pull request carries at that commit against develop, and it recorded 0 findings.

[coderabbitai]

Caution

Review failed

The pull request is closed.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Fail comparisons when only one run has a file's track dump

🐞 Bug fix 🧪 Tests 📝 Documentation 🕐 10-20 Minutes

AI Description

• Treat a track dump missing from one run as a failure, even when the other dump is empty.
• Name the run missing the dump without changing comparisons where both runs have dumps.
• Test both missing-run directions and document the comparison rule.

Diagram

graph TD
  A["Baseline log"] --> C["Last dumps"] --> D{"Both dumped file?"} -->|Yes| E{"Tracks equal?"} -->|No| F["Fail comparison"]
  B["Results log"] --> C
  D -->|No: name run| F
  E -->|Yes| G["Tracks match"]

Loading

High-Level Assessment

Checking dictionary membership before comparing track lists is the appropriate fix: it preserves the distinction between an empty dump and no dump, while leaving existing comparisons of two present dumps intact. No meaningfully different architecture is warranted for this localized change.

Files changed (3) +23 / -5

Bug fix (1) +10 / -4

check_results.pyDistinguish missing dumps from empty track lists +10/-4

Distinguish missing dumps from empty track lists

• Checks whether each file has a dump in both runs before comparing its tracks. A one-sided dump produces an error naming the run without it.

RegressionTests/check_results.py

Tests (1) +12 / -0

test_check_results.pyCover one-sided empty dumps in both directions +12/-0

Cover one-sided empty dumps in both directions

• Adds a run-comparison test that places an empty dump for a second file on either side and verifies failure and the missing-run diagnostic.

RegressionTests/tests/test_check_results.py

Documentation (1) +1 / -1

README.mdDocument one-sided track dumps as differences +1/-1

Document one-sided track dumps as differences

• Clarifies that a file dumped in only one run differs even if its dump contains no tracks.

RegressionTests/README.md

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can see how risky a PR is at a glance with blast radius labels

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[Copilot]

🟢 Approval recommended

No active review issues are identified, and the change includes targeted coverage and documentation for distinguishing missing dumps from valid empty dumps.

No open issues 🎉

What changed in this PR

Updates regression-run track comparison so a file with a track dump in only one run is treated as a mismatch rather than compared against an implicit empty track list.

Changes:

• Distinguishes missing per-file track dumps from valid empty dumps.
• Adds regression coverage for one-sided dumps in both comparison directions.
• Documents the updated comparison behavior.

File	Description
RegressionTests/​tests/​test_check_results.py	Tests missing per-file dumps in both baseline/results directions.
RegressionTests/​README.md	Documents that one-sided per-file dumps fail comparison.
RegressionTests/​check_results.py	Reports which run lacks a per-file track dump while preserving valid empty-dump matches.

_{Review effort: Lite}

[ptr727]

@coderabbitai review

[coderabbitai]

Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.