[ptr727]

Summary

Promotes #1239 and #1242 to main.

• Skip the Carried Verbatim Trees in the Reviewer Configs #1239 excludes the carried hub trees .github/skills/** and lib/fleet/sh/** from CodeRabbit and Qodo review, so findings on them go to the hub.
• Resync the Carried Instruction Set and Fleet Skills with the Hub #1242 resyncs the carried instruction set and fleet skills tree with the hub at 9f3e03c. It re-vendors the stale verbatim sections of AGENTS.md and GOVERNANCE.md, refreshes .github/skills/ with decision-triage added and unattended-handoff pruned, and brings the carried CODESTYLE.md and .github/copilot-instructions.md lines level with the skills. It also adds .vscode/settings.json to .gitignore and to a root .prose-gate.json.

Qodo reads .pr_agent.toml from the default branch, so #1239's exclusion takes effect for Qodo once this merges.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The CodeRabbit and PR Agent configurations now exclude .github/skills/** and lib/fleet/sh/** from review.

Changes: Review configuration

Layer / File(s)	Summary
Configure ignored paths .coderabbit.yaml, .pr_agent.toml	Both configurations exclude .github/skills/** and lib/fleet/sh/** from review.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

• ptr727/PlexCleaner#1064: This PR modifies files under .github/skills/**, which these configuration changes exclude from review.

Suggested labels: chore

Merge Risk: Minimal · up to 5f32e

The changes declare exclusions for both carried trees. No concrete merge-blocking defect was established.

Pre-merge checks: 4

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title describes promoting the develop changes and syncing the instruction set and fleet skills with the hub. It is related to the pull request’s reviewer-configuration changes for those carried tr…

Full details: Title check

Explanation

The title describes promoting the develop changes and syncing the instruction set and fleet skills with the hub. It is related to the pull request’s reviewer-configuration changes for those carried trees.

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: ptr727/PlexCleaner
• Branch: develop
• File: .coderabbit.yaml
• Commit: 5f32edd
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: e71c3d9f-4b63-44a7-b24c-af09cf69c539

Commits

Reviewing files that changed from the base of the PR and between ae3e5f7 and 5f32edd.

Files selected for processing: 2

• .coderabbit.yaml
• .pr_agent.toml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Exclude Hub-Carried Trees from CodeRabbit and Qodo Reviews

⚙️ Configuration changes 🕐 Less than 10 minutes

AI Description

• Exclude verbatim hub-carried skill and shell trees from CodeRabbit and Qodo reviews.
• Keep findings on shared content directed to its upstream hub.

Diagram

graph TD
  A["PR paths"] --> B["CodeRabbit filter"] --> D["Reviewed paths"]
  A --> C["Qodo ignore"] --> D
  E["Carried trees"] --> F["Upstream hub"]
  B -. "skips" .-> E
  C -. "skips" .-> E

Loading

High-Level Assessment

Keep the exclusions in each bot's native configuration, as the PR does. A single repository policy cannot replace the bot-specific path filters; retaining the hub as the source for rendered configuration avoids separate local policy.

Files changed (2) +6 / -0

Other (2) +6 / -0

.coderabbit.yamlExclude carried trees from CodeRabbit review +3/-0

Exclude carried trees from CodeRabbit review

• Adds negative path filters for .github/skills/** and lib/fleet/sh/**, leaving other CodeRabbit review settings unchanged.

.coderabbit.yaml

.pr_agent.tomlExclude carried trees from Qodo review +3/-0

Exclude carried trees from Qodo review

• Adds ignore globs for the same skill and shell trees so Qodo does not review verbatim hub-carried content.

.pr_agent.toml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Review bots skip findings on two trees 📘 Rule violation ✧ Quality

Description

The new path_filters entries in .coderabbit.yaml and the [ignore] glob in .pr_agent.toml
exclude .github/skills/** (and lib/fleet/sh/**) from CodeRabbit and Qodo review, so any
supported finding on those paths is hidden by default. The exclusion is driven by repo-added
configuration rather than the tools' own suppression metadata, and it covers future edits under
those trees, including about 40 skill files that steer agent behaviour and may differ from the hub
copies that nothing in this PR verifies.

Code

.coderabbit.yaml[R7-9]

+  path_filters:
+    - "!.github/skills/**"
+    - "!lib/fleet/sh/**"

Evidence

Both reviewer configs add path-based exclusions that hide findings by default on the listed trees,
and the glob listing shows about 40 skill files under .github/skills/ now excluded from review.
Compliance rule 3008765 requires that hiding of supported findings be driven only by the underlying
tool's own suppression metadata, not reviewer- or pipeline-added configuration. The
carried-instruction-file-guard skill notes that carried hub files can hold local additions differing
from the hub, so these trees are not guaranteed identical, and excluding them leaves locally edited
agent instructions with no automated review.

Rule 3008765: Do not hide or downgrade supported static analysis findings in review output
.coderabbit.yaml[7-9]
.pr_agent.toml[4-5]
.github/skills/unattended-handoff/SKILL.md: .github/skills/unattended-handoff/SKILL.md: .github/skills/unattended-handoff/SKILL.md: .github/skills/unattended-handoff/SKILL.md
.github/skills/carried-instruction-file-guard/SKILL.md[1-42]
.pr_agent.toml[3-5]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR excludes `.github/skills/**` and `lib/fleet/sh/**` from CodeRabbit and Qodo review through repo-added configuration, so supported findings on those paths are hidden by default. This violates compliance rule 3008765, which requires hiding of supported findings to be driven only by the underlying tool's own suppression metadata. The `.github/skills/` tree holds about 40 SKILL.md and reference files that steer agent behaviour, including destructive-action and unattended-run guidance. Locally edited copies may differ from the hub, and nothing in this PR verifies they are byte-identical, so a defect or injected instruction would merge with no automated review.
## Fix Focus Areas
- .coderabbit.yaml[4-9]
- .pr_agent.toml[1-5]
## Recommended Fix
Remove the `path_filters` exclusions for `.github/skills/**` and `lib/fleet/sh/**` from `.coderabbit.yaml`, and remove the `[ignore]` glob from `.pr_agent.toml`, so CodeRabbit and Qodo keep publishing findings on these trees. If the goal is only to avoid duplicate findings on byte-identical hub copies, add a CI check that fails when these files differ from the hub checkout, and limit any review exclusion to files verified identical. If routing to the hub is intended, document it in the reviewer config comments and keep the findings visible in the review output.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. Shell exclusion for lib/fleet/sh matches no files 🐞 Bug ⚙ Maintainability

Description

The lib/fleet/sh/** glob added to .coderabbit.yaml and .pr_agent.toml matches nothing in this
checkout because there is no lib/ directory. If that tree is later added locally, its shell
scripts will be silently excluded from review without any reviewer noticing.

Code

.pr_agent.toml[5]

+glob = [".github/skills/**", "lib/fleet/sh/**"]

Evidence

Listing /lib fails with path_not_found and the glob for lib/fleet/sh/** returns no files, so the
exclusion has no effect today. It is a latent gap that would take effect silently the first time
shell code is placed under that path.

.pr_agent.toml[4-5]
.coderabbit.yaml[8-9]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The `lib/fleet/sh/**` exclusion in both reviewer configs matches no files in this repository and would silently hide shell scripts if that path is added later.
## Fix Focus Areas
- .coderabbit.yaml[8-9]
- .pr_agent.toml[5-5]
## Recommended Fix
Remove the `lib/fleet/sh/**` entry from both files until the tree exists here. If it is later carried in, add the exclusion in the same change that adds the files, with a comment naming the hub source.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can move or hide resolved findings to focus on what still needs action

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[Copilot]

🟢 Approval recommended

No active review issues are present, and the reviewer configurations consistently exclude the specified carried hub-owned trees while preserving existing settings.

No open issues 🎉

What changed in this PR

This pull request updates automated reviewer configurations so carried, hub-owned trees are excluded from repository-level reviews and handled at their canonical source.

Changes:

• Excludes .github/skills/** and lib/fleet/sh/** from Qodo PR Agent reviews.
• Adds the same path filters to CodeRabbit.
• Preserves existing reviewer configuration.

File	Description
.pr_agent.toml	Excludes carried hub trees from Qodo reviews.
.coderabbit.yaml	Excludes carried hub trees from CodeRabbit reviews.

_{Review effort: Lite}

[ptr727]

@coderabbitai review

[coderabbitai]

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[ptr727]

@qodo-free-for-open-source-projects please dismiss findings 1 and 2.

1. .coderabbit.yaml:7-9 and .pr_agent.toml:4-5, review bots skip findings on two trees: Disproven as a defect, out of scope. The exclusion is the deliberate fleet policy rendered by the hub (Skip Carried Verbatim Trees in Rendered Reviewer Configs ProjectTemplate#4020) and already reviewed and merged to develop as Skip the Carried Verbatim Trees in the Reviewer Configs #1239. Qodo's compliance rule 3008765 is not a rule of this repository, and findings on those trees are filed at the hub, where the text originates.
2. .pr_agent.toml:4-5, lib/fleet/sh exclusion matches no files: No change needed. gh api repos/ptr727/PlexCleaner/contents/lib/fleet?ref=develop returns 404, so the glob is a harmless no-op here. The hub renders one uniform config for every repository, so it stays identical across the fleet.

[qodo-free-for-open-source-projects]

free-for-open-source-projects please dismiss findings 1 and 2.

1. .coderabbit.yaml:7-9 and .pr_agent.toml:4-5, review bots skip findings on two trees: Disproven as a defect, out of scope. The exclusion is the deliberate fleet policy rendered by the hub (Skip Carried Verbatim Trees in Rendered Reviewer Configs ProjectTemplate#4020) and already reviewed and merged to develop as Skip the Carried Verbatim Trees in the Reviewer Configs #1239. Qodo's compliance rule 3008765 is not a rule of this repository, and findings on those trees are filed at the hub, where the text originates.
2. .pr_agent.toml:4-5, lib/fleet/sh exclusion matches no files: No change needed. gh api repos/ptr727/PlexCleaner/contents/lib/fleet?ref=develop returns 404, so the glob is a harmless no-op here. The hub renders one uniform config for every repository, so it stays identical across the fleet.

I can't dismiss findings 1 and 2 right now. This PR's findings catalog is currently empty, so I can't match those report numbers to stable finding IDs. Nothing has been changed.

Once the findings are indexed, ask again and I'll dismiss them. Dismissal only works if you're the PR author. If the review data looks stale, I can also re-run the review, but only if you ask.

[Copilot]

🔵 Needs a closer look

Approval should wait for hub-source adjudication and live reviewer-behavior checks because the broad policy resync contains generated control-flow contradictions and changes merge/review mechanics.

No open issues 🎉

_{Review effort: Lite}

[ptr727]

Answers on head d2fd0b4. @qodo-free-for-open-source-projects please dismiss findings 1 and 2.

• Copilot verdict, "needs a closer look": declined, no defect named. The "generated control-flow contradictions" are the carried hub skill text in .github/skills/ (Qodo raised two on Resync the Carried Instruction Set and Fleet Skills with the Hub #1242). That tree is byte-identical to the hub at 9f3e03cf, so any fix lands at ptr727/ProjectTemplate and reaches here at the next resync. The "live reviewer-behavior checks" can only run once this merges, since Qodo reads .pr_agent.toml from main. Merging main is the maintainer's call either way.
• Qodo 1, review bots skip findings on two trees: declined, out of scope. The exclusion is the fleet policy the hub renders, reviewed and merged as Skip the Carried Verbatim Trees in the Reviewer Configs #1239. Findings on those trees are filed at the hub, where the text originates.
• Qodo 2, the lib/fleet/sh exclusion matches no files: no change needed. lib/ does not exist here, so the glob is a no-op. The hub renders one uniform config for every repository.

[qodo-free-for-open-source-projects]

Answers on head d2fd0b4. @qodo-free-for-open-source-projects please dismiss findings 1 and 2.

• Copilot verdict, "needs a closer look": declined, no defect named. The "generated control-flow contradictions" are the carried hub skill text in .github/skills/ (Qodo raised two on Resync the Carried Instruction Set and Fleet Skills with the Hub #1242). That tree is byte-identical to the hub at 9f3e03cf, so any fix lands at ptr727/ProjectTemplate and reaches here at the next resync. The "live reviewer-behavior checks" can only run once this merges, since Qodo reads .pr_agent.toml from main. Merging main is the maintainer's call either way.
• Qodo 1, review bots skip findings on two trees: declined, out of scope. The exclusion is the fleet policy the hub renders, reviewed and merged as Skip the Carried Verbatim Trees in the Reviewer Configs #1239. Findings on those trees are filed at the hub, where the text originates.
• Qodo 2, the lib/fleet/sh exclusion matches no files: no change needed. lib/ does not exist here, so the glob is a no-op. The hub renders one uniform config for every repository.

I can't dismiss findings 1 and 2 right now. The findings index for this PR is empty, so I can't match them to stable IDs. The published report lists them as findings 1 and 2, but I have no record of them to act on.

Once the index is populated, I can dismiss them. Only the PR author can dismiss findings, so the request has to come from the author. You can also reply with the finding titles to confirm which ones you mean:

• finding 1: Review bots skip findings on two trees (rule violation)
• finding 2: Shell exclusion for lib/fleet/sh matches no files (bug)

[Copilot]

🔵 Needs a closer look

Defer because the 34-file instruction and reviewer-policy resync relies on external hub parity and CodeRabbit/Qodo behavior that cannot be independently validated from this checkout, requiring maintainer confirmation of the hub audit and generated-tree fidelity.

No open issues 🎉

_{Review effort: Lite}

[ptr727]

Copilot's third round on d2fd0b4 asks for confirmation of hub parity and generated-tree fidelity. Declined as a finding, with that evidence on #1242: spec/audit.py --branch develop PlexCleaner at hub 9f3e03cf classified every re-vendored section and skill as stale with no local edit, carry.py asserted the untouched regions byte-identical, and diff -rq of .github/skills against the hub is empty. Qodo and CodeRabbit behavior under the #1239 configs can only be observed once this reaches main. Neither round stated coverage, so this promotion goes to the maintainer under Merge Gate item 2.