Skip to content

Commit ProjectTemplate's Registry-Rendered Agent Policy Files - #3895

Merged
ptr727 merged 1 commit into
developfrom
feature/render-agent-policy-pilot
Nov 6, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/render-agent-policy-pilot

Conversation

@ptr727

@ptr727 ptr727 commented Nov 6, 2026

Copy link
Copy Markdown
Owner

Summary

Commits the hub's own rendered agent policy files, the first part of the policy-driven review pilot. scripts/agent_policy.py write rendered them from registry/repos.json. ProjectTemplate takes the release workflow model and has no agentPolicy override. The hub then carries its rendered files before any account-level automatic review toggle goes off.

  • .github/agent-policy.json is new. It is the hub default: Copilot, CodeRabbit, and Qodo each trigger: auto, and guard: {} for the release model.
  • .pr_agent.toml gains [config] disable_auto_feedback = false, stating Qodo's automatic review explicitly. It matches pr-agent's own default.
  • .coderabbit.yaml renders byte-identical and is unchanged.

Behavior does not change. scripts/pr_review.py reads the same bot settings it reads today from spec/agent-policy.default.json, and gh-write-guard reads guard: {} as no exemption, the same as an absent file. Moving the hub to explicit review is a later change, through a registry agentPolicy override.

The files were written with agent_policy.py write rather than repo-config/configure.sh apply --checkout, since apply also writes the repository's settings, labels, and rulesets. The files are the same either way.

Verification

  • agent_policy.py check --ref feature/render-agent-policy-pilot reports all four items ok: the policy file equals the render, .coderabbit.yaml's auto_review.enabled and base_branches, and .pr_agent.toml's disable_auto_feedback.
  • A recorded local strict pass at the frontier tier found 0 findings, and prose_lint.py --diff printed no violation.

🤖 Generated with Claude Code

Write the hub's own .github/agent-policy.json and the bot-side keys it
implies, rendered by scripts/agent_policy.py from registry/repos.json,
so the hub carries the files before any account-level toggle goes off.

The render keeps today's behavior: all three bots review automatically,
and .pr_agent.toml now states disable_auto_feedback = false explicitly.
.coderabbit.yaml renders byte-identical. Moving the hub to explicit
review is a later registry agentPolicy override.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings November 6, 2026 02:33
@ptr727

ptr727 commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 93ff672fee5034336be45a1e8aebd2e056dd86d1, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified, and the changes are limited to making existing agent-policy defaults explicit while preserving the current bot and guard configuration.

No open issues 🎉

What changed in this PR

This PR commits ProjectTemplate’s registry-rendered agent policy files, making the hub’s default release-model review settings explicit while preserving the effective bot and guard configuration. The explicit policy also changes backlog metrics from auto (default) to auto.

Changes:

  • Adds .github/agent-policy.json with automatic Copilot, CodeRabbit, and Qodo reviews and an empty guard configuration.
  • Sets Qodo’s disable_auto_feedback = false explicitly in .pr_agent.toml.
  • Leaves the existing CodeRabbit configuration unchanged.
File Description
.pr_agent.toml Records Qodo’s automatic feedback setting explicitly while preserving the existing configuration.
.github/​agent-policy.json Adds the registry-rendered release-model agent policy and makes the hub defaults explicit.

Review effort: Lite

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.87%. Comparing base (b998a7c) to head (93ff672).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3895   +/-   ##
========================================
  Coverage    77.87%   77.87%           
========================================
  Files           34       34           
  Lines        12085    12085           
========================================
  Hits          9411     9411           
  Misses        2674     2674           
Flag Coverage Δ
python-3.13 77.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit d8f8161 into develop Nov 6, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/render-agent-policy-pilot branch November 6, 2026 02:43
ptr727 added a commit that referenced this pull request Nov 6, 2026
…3898)

## Summary

Promotes #3895 to `main`.

- **The hub's own rendered agent policy files (#3895).** This commits
`.github/agent-policy.json` and adds `[config] disable_auto_feedback =
false` to `.pr_agent.toml`, both rendered from `registry/repos.json` by
`scripts/agent_policy.py`. The render matches today's behavior: Copilot,
CodeRabbit, and Qodo each review automatically, and `guard` is empty for
the release model. This is the first part of the policy-driven review
pilot. Once it is on `main`, `configure.sh check` stops reporting
agent-policy drift on ProjectTemplate. A later registry `agentPolicy`
override moves the hub to explicit review.

The feature pull request carried a recorded local strict pass with no
findings, and Copilot's round on it was clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants