Repository navigation
Move the Hub's Own Bot Reviews to Explicit Requests - #3899
Conversation
Adds a registry agentPolicy override for ProjectTemplate and commits the files scripts/agent_policy.py renders from it. All three bots go explicit, each asked only once the head's checks are green. - Copilot: explicit on the default branch, a round per push, capped at 3. Past the cap an attested local pass covers a new head. - CodeRabbit and Qodo: explicit on main and develop, asked once per pull request. Neither gates. The render turns off CodeRabbit's auto_review and sets Qodo's disable_auto_feedback. It also drops the copilot_code_review rule from the main ruleset at the next configure.sh apply. The develop ruleset carries no such rule. docs/pr-reviewer-reference.md now says CodeRabbit's automatic review is off. Rollback is reverting this commit and then running configure.sh apply, which restores the main ruleset's Copilot rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
There was a problem hiding this comment.
🔵 Needs a closer look
Defer because promotion depends on maintainer-controlled live settings and a configure.sh apply sequence that cannot be verified from this diff.
No open issues 🎉
What changed in this PR
This pull request moves ProjectTemplate’s bot reviews from automatic triggers to explicit, policy-driven requests while preserving the configured review coverage and limits.
Changes:
- Adds a ProjectTemplate-specific
agentPolicyoverride for Copilot, CodeRabbit, and Qodo. - Configures explicit after-checks reviews, with Copilot capped at three rounds.
- Disables automatic CodeRabbit and Qodo feedback.
- Documents the updated CodeRabbit review behavior.
| File | Description |
|---|---|
registry/repos.json |
Defines ProjectTemplate’s explicit bot review policy override. |
docs/pr-reviewer-reference.md |
Documents CodeRabbit’s explicit-request behavior. |
.pr_agent.toml |
Disables automatic Qodo feedback. |
.github/agent-policy.json |
Renders the explicit review policy and round limits. |
.coderabbit.yaml |
Disables automatic CodeRabbit reviews while retaining the develop base. |
Review effort: Lite
|
Listed in the body. The verdict headline flags the dependency on the live |
run_gate_on_files copies the real registry into a scratch tree, and the gate imports scripts/agent_policy.py for any entry carrying an agentPolicy. ProjectTemplate's entry is now the first to carry one, so the gate crashed on the missing module before reaching the loop each case asserts on. The scratch tree now carries agent_policy.py and the two modules it imports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3899 +/- ##
========================================
Coverage 77.87% 77.87%
========================================
Files 34 34
Lines 12085 12085
========================================
Hits 9411 9411
Misses 2674 2674
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Step 1 of the review-cutover track (#3877): moves the hub's own pull request reviews from automatic to explicit requests, through a registry
agentPolicyoverride and the filesscripts/agent_policy.py writerenders from it. The maintainer chose the values on 2026-11-05.registry/repos.jsongains ProjectTemplate'sagentPolicyoverride. Only the fields that differ fromspec/agent-policy.default.jsonare stated..github/agent-policy.json,.coderabbit.yaml(auto_review.enabled: false), and.pr_agent.toml(disable_auto_feedback = true) are the render.docs/pr-reviewer-reference.mdnow says CodeRabbit's automatic review is off.tests/test_spec_validate.py:run_gate_on_filescopies the real registry, and the gate importsscripts/agent_policy.pyfor an entry carryingagentPolicy. ProjectTemplate's is the first such entry, so the scratch tree now carries that module and the two it imports. Without them the gate crashed withModuleNotFoundError, which failed the first CI run.The render also drops the
copilot_code_reviewrule from themainruleset at the nextrepo-config/configure.sh apply. Thedevelopruleset carries no such rule.Sequencing
configure.sh applyagainst ptr727/ProjectTemplate runs before the promotion that carries this file tomain, with the maintainer's go-ahead at the time. Otherwise the ruleset's own Copilot trigger reviews promotion pushes alongside the explicit request.configure.sh apply.Verification
uv run --no-project --with-requirements tests/requirements.txt --with pytest python spec/validate.py:Spec validation OK.python -m pytest -q tests: 3583 passed, 11 skipped.scripts/agent_policy.py facts:copilotRulefalse on main and develop, CodeRabbitenabledfalse withbase_branches ["^develop$"], Qododisable_auto_feedbacktrue.🤖 Generated with Claude Code