Deprecate RepositoryVersion.content_batch_qs - #8088
Open
gerrod3 wants to merge 1 commit into
Open
Conversation
mdellweg
reviewed
Sep 11, 2026
Comment on lines
+1074
to
+1075
| deprecation_logger.warning( | ||
| "content_batch_qs is deprecated. Use get_content with .iterator() instead." |
Member
There was a problem hiding this comment.
Please add a removal version. (Even if we know we might be pushing them out.)
dralley
previously approved these changes
Sep 11, 2026
Assisted-by: gpt-5.6-sol
gerrod3
force-pushed
the
rv-content-batches-deprecate
branch
from
September 11, 2026 18:35
579a8d7 to
d17cef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking to sol it pointed out this method is really bad, it does the
unnest(content_ids)operation for each slice it generates. No plugin seems to use this and django's.iterator()method does what we need. If you need batches you can wrap the iterator call withitertools.batchesand it will be correct without paying the unnest penalty for each batch.Assisted-by: gpt-5.6-sol
📜 Checklist
See: Pull Request Walkthrough