ci(semver): compare rivet-core against the PR's base branch, not an unrelated crates.io crate (#968) - #975
Open
avrabe wants to merge 1 commit into
Open
ci(semver): compare rivet-core against the PR's base branch, not an unrelated crates.io crate (#968)#975avrabe wants to merge 1 commit into
avrabe wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…nrelated crates.io crate (#968) The semver gate is a CI Gate need, and it checked nothing. `cargo semver-checks check-release` with no baseline takes its baseline from crates.io. The `rivet-core` there is an unrelated 0.1.0, so every PR reported `0 checks: 0 pass, 254 skip` and passed. The ci.yml comment said it compared "relative to the base branch", and it never did. It now runs with `--baseline-rev origin/<base>` and fetches full history. Checked locally with cargo-semver-checks 0.50.0 against origin/main: no change exit 0 196 checks: 196 pass, 58 skip pub fn load_schemas renamed exit 100 function_missing (1 fail) same rename + workspace 0.38.0 exit 0 0 checks: 0 pass, 254 skip The third row is the escape hatch, which the maintainer chose. An intended break is allowed by bumping the workspace version in the same PR, so the break is visible in the diff. Its output has the same shape as the vacuous run this fixes, so the step now prints a GitHub warning whenever zero checks ran. The shell logic was tested with a stand-in command for all three outcomes. A normal pass exits 0 with no warning, a real failure keeps exit 100 through the tee pipe, and a zero-check run exits 0 with the warning. yamllint exits 0, and actionlint reports nothing beyond the pre-existing custom runner labels. No Rust source changes. Refs: DD-063 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9
avrabe
force-pushed
the
ci/semver-baseline-rev
branch
from
September 17, 2026 18:26
aac9d3d to
1e6444c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 1e6444c | Previous: f16245a | Ratio |
|---|---|---|---|
store_insert/10000 |
19081537 ns/iter (± 1483168) |
12844170 ns/iter (± 331034) |
1.49 |
store_lookup/100 |
1941 ns/iter (± 4) |
1606 ns/iter (± 10) |
1.21 |
store_lookup/10000 |
356081 ns/iter (± 3057) |
289329 ns/iter (± 1813) |
1.23 |
store_by_type/100 |
95 ns/iter (± 2) |
76 ns/iter (± 0) |
1.25 |
store_by_type/1000 |
95 ns/iter (± 0) |
76 ns/iter (± 0) |
1.25 |
store_by_type/10000 |
95 ns/iter (± 0) |
76 ns/iter (± 0) |
1.25 |
diff/1000 |
719479 ns/iter (± 6170) |
581112 ns/iter (± 7534) |
1.24 |
diff/10000 |
10477173 ns/iter (± 581313) |
7291375 ns/iter (± 149125) |
1.44 |
query/1000 |
14514 ns/iter (± 75) |
11672 ns/iter (± 131) |
1.24 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968. The maintainer chose this option: compare against the PR base, with a version bump as the way to allow an intended break.
The problem
Semver Checks (rivet-core public API)is a required need ofCI Gate. With no baseline flag,cargo semver-checkscompares against crates.io, whererivet-coreis an unrelated 0.1.0. Every PR ran0 checks: 0 pass, 254 skipand passed.The change
--baseline-rev "origin/${{ github.base_ref }}", plusfetch-depth: 0so the base ref exists.::warningwhenever 0 checks run. A version bump legitimately runs zero checks, and without the warning that looks exactly like the empty comparison this PR fixes.Local evidence (cargo-semver-checks 0.50.0, against
origin/main)196 checks: 196 pass, 58 skippub fn load_schemas(negative control)function_missing: pub fn removed or renamed0 checks: 0 pass, 254 skip→ warningThe step's shell logic was tested with a stand-in command. A normal pass exits 0 with no warning. A real failure keeps exit 100 through the
teepipe. A zero-check run exits 0 with the warning.What this changes for upcoming PRs
Artifact.fields' public type. The gate will now fail it unless that PR also bumps the minor version.yamllint 0; actionlint reports nothing beyond the pre-existing custom runner labels (
rust-cpu,light,lean-mem). No Rust source changes.🤖 Generated with Claude Code
https://claude.ai/code/session_015HMQUV3u86jN2hmCtXNTc9